Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check permission before recall #1662

Merged
merged 6 commits into from
Nov 10, 2021
Merged

check permission before recall #1662

merged 6 commits into from
Nov 10, 2021

Conversation

Nambers
Copy link
Contributor

@Nambers Nambers commented Nov 7, 2021

close #1175

@Nambers
Copy link
Contributor Author

Nambers commented Nov 7, 2021

里面群成员离开后应该用什么permission还要确认(是原先的permission还是member permission)
但是由于撤回退出群成员的信息会抛出异常 #1661
所以目前还测试不出来

@Him188
Copy link
Member

Him188 commented Nov 7, 2021

请添加一个测试

@Him188 Him188 added this to the 2.9 milestone Nov 7, 2021
@Him188 Him188 added the N 优先级: 一般 label Nov 7, 2021
@Nambers
Copy link
Contributor Author

Nambers commented Nov 7, 2021

请添加一个测试

用mock frame吗?
晚点去看看

@Nambers Nambers marked this pull request as draft November 7, 2021 11:04
@Him188
Copy link
Member

Him188 commented Nov 7, 2021

可以看 mirai-core/commonTest

@Nambers
Copy link
Contributor Author

Nambers commented Nov 7, 2021

可以看 mirai-core/commonTest

@Him188 这种吗?
groupMessageSource是你之前发我的那个

@Karlatemp Karlatemp added the t:enhancement 类型: 现有功能上的优化 label Nov 7, 2021
@Nambers Nambers marked this pull request as ready for review November 7, 2021 16:07
@Nambers Nambers requested a review from Karlatemp November 8, 2021 04:20
@Karlatemp Karlatemp added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Nov 8, 2021
@Him188 Him188 modified the milestones: 2.9, 2.9.0-M1 Nov 9, 2021
@Him188
Copy link
Member

Him188 commented Nov 9, 2021

这个 PR 会修复 #1661 吗 @Nambers

@Him188 Him188 removed the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Nov 9, 2021
@Nambers
Copy link
Contributor Author

Nambers commented Nov 10, 2021 •
edited
Loading

这个 PR 会修复 #1661 吗 @Nambers

不会，1661是impl onlineMessageSource的报错
这个只是加了个缺少的权限检查

这个和1661有一点相关性是因为里面取发送者为空的时候需要返回一个默认权限，但是由于1661在发送者退出群的时候正常执行撤回，所以不能完全确认这里应该返回什么权限

我在客户端测试的时候是管理员可以撤回退出群的管理员的信息，所以我推测应该是返回Member权限

@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Nov 10, 2021
@Him188 Him188 merged commit 12e3c4f into mamoe:dev Nov 10, 2021
@Nambers Nambers deleted the recallcheck branch November 10, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
N 优先级: 一般 t:enhancement 类型: 现有功能上的优化 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.9.0-M1
Development

Successfully merging this pull request may close these issues.

在 MessageSource.recall 时预先检查权限
3 participants
@Nambers @Him188 @Karlatemp