Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioToSilkService #1591

Merged
merged 3 commits into from
Oct 9, 2021
Merged

AudioToSilkService #1591

merged 3 commits into from
Oct 9, 2021

Conversation

Karlatemp
Copy link
Member

close #1249

@Karlatemp Karlatemp added t:feature 类型: 新特性 N 优先级: 一般 labels Oct 2, 2021
@Karlatemp Karlatemp requested a review from Him188 October 2, 2021 13:10
@Him188
Copy link
Member

Him188 commented Oct 2, 2021

转换的实现在哪

@Karlatemp
Copy link
Member Author

Karlatemp commented Oct 2, 2021 •
edited
Loading

just spi, 实现打算另外开个仓库具体实现

@Him188
Copy link
Member

Him188 commented Oct 2, 2021 •
edited
Loading

我建议给 ER 加一个 val origin: Any 来提供其原文件地址

现在这个 low level 实现不太好

@Him188 Him188 added this to the 2.8.0-RC milestone Oct 5, 2021
@AdoptOSS
Copy link
Contributor

AdoptOSS commented Oct 6, 2021

其实个人感觉core模块专注于协议本身会更好一点？这些附加功能没必要做太多？
当然客观的说，目前的设计上这些东西似乎很难放到console里面去，毕竟console直接公开了core的接口

Him188
Him188 reviewed Oct 8, 2021
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and @since

@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Oct 8, 2021
@Him188 Him188 merged commit b31f7b1 into dev Oct 9, 2021
@Him188 Him188 deleted the audio-convert-spi branch October 9, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nambers Nambers Nambers left review comments

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
N 优先级: 一般 t:feature 类型: 新特性 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.8.0-RC
Development

Successfully merging this pull request may close these issues.

添加 MP3 到 silkv3 转码支持
4 participants
@Karlatemp @Him188 @AdoptOSS @Nambers