Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign group files #1589

Merged
merged 39 commits into from
Oct 30, 2021
Merged

Redesign group files #1589

merged 39 commits into from
Oct 30, 2021

Conversation

Him188
Copy link
Member

@Him188 Him188 commented Oct 1, 2021 •
edited
Loading

TODO:

  • refresh
  • TODO: 2021/10/1 try optimize exists
  • Deprecate old
  • Check permission
  • TODO: 2021/10/1 handle file not exists to return null
  • tests

@Him188 Him188 added the t:enhancement 类型: 现有功能上的优化 label Oct 1, 2021
@Him188 Him188 requested a review from Karlatemp October 1, 2021 00:14
@Him188
Copy link
Member Author

Him188 commented Oct 1, 2021 •
edited by Karlatemp
Loading

Moved to top

@Him188 Him188 requested a review from Karlatemp October 1, 2021 16:58
Karlatemp
Karlatemp reviewed Oct 2, 2021
View reviewed changes
@Him188 Him188 added this to the 2.8.0-RC milestone Oct 2, 2021
This was linked to issues Oct 3, 2021
重新设计 RemoteFile #1328
Closed
关于不同终端RemoteFile得到空指针的问题 #1453
Closed
Karlatemp
Karlatemp reviewed Oct 10, 2021
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API reviewed

@Him188 Him188 marked this pull request as ready for review October 30, 2021 12:35
@Him188 Him188 requested a review from Karlatemp October 30, 2021 12:35
@Him188
Copy link
Member Author

Him188 commented Oct 30, 2021

All tested

@Him188
Copy link
Member Author

Him188 commented Oct 30, 2021

由于无法检测群设置中的允许任何人上传文件, 移除了对文件操作的提前权限检测, 权限错误会在发包得到服务器错误后才会抛出.

经测试, 即使允许任何人上传, 目录的 move, delete 仍需要管理员权限

@Him188 Him188 requested a review from Karlatemp October 30, 2021 13:52
@Him188 Him188 merged commit 9e151e7 into dev Oct 30, 2021
@Him188 Him188 deleted the new-files-design branch October 30, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nambers Nambers Nambers left review comments

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
t:enhancement 类型: 现有功能上的优化
Projects
None yet
Milestone
2.8.0-RC
Development

Successfully merging this pull request may close these issues.

关于不同终端RemoteFile得到空指针的问题 重新设计 RemoteFile
3 participants
@Him188 @Karlatemp @Nambers