Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine MessageSource #1568

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Refine MessageSource #1568

merged 2 commits into from
Sep 27, 2021

Conversation

Karlatemp
Copy link
Member

fix #1532

@Karlatemp Karlatemp added t:bug 类型: bug N 优先级: 一般 labels Sep 20, 2021
@Karlatemp Karlatemp requested a review from Him188 September 20, 2021 14:21
Him188
Him188 requested changes Sep 21, 2021
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该让 IncomingMessageSourceInternal 实现 RefinableMessage 然后在其 light refine 中实现

@Karlatemp
Copy link
Member Author

这是需要的是最终完整 refined 之后的结果 (也就是 refineDeep 之后的), 在 refineLight 执行会有逻辑错误 @Him188

@Karlatemp Karlatemp requested a review from Him188 September 21, 2021 08:04
@Him188
Copy link
Member

Him188 commented Sep 21, 2021

@Karlatemp 加个注释

@Karlatemp Karlatemp added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Sep 21, 2021
@Him188 Him188 added this to the 2.8.0-RC milestone Sep 21, 2021
@Him188 Him188 merged commit 5fe9ad0 into dev Sep 27, 2021
@Him188 Him188 deleted the msgsrc-refine branch September 27, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
N 优先级: 一般 t:bug 类型: bug z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.8.0-RC
Development

Successfully merging this pull request may close these issues.

序列化接收到的forwardMessage的MessageSource报错
2 participants
@Karlatemp @Him188