Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mirai-bom for dependency management #1417

Merged
merged 3 commits into from
Oct 9, 2021
Merged

Introduce mirai-bom for dependency management #1417

merged 3 commits into from
Oct 9, 2021

Conversation

AdoptOSS
Copy link
Contributor

@Karlatemp Karlatemp added the t:feature 类型: 新特性 label Jul 14, 2021
Karlatemp
Karlatemp reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@Karlatemp Karlatemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢你的帮助, 在确定下一步评估之前我们需要先确定以下内容

  • publishToLocal successful? (GPG sign successful required)
  • api(platform("net.mamoe:mirai-bom")) 是否会直接导入 mirai-console
  • Gradle Kotlin JVM Project 引用正常? (require resolved to *-jvm)
  • Gradle Kotlin Android Project 引用正常? (require resolved to *-android)

@Him188 Him188 added this to the 2.9 milestone Jul 16, 2021
@AdoptOSS
Copy link
Contributor Author

AdoptOSS commented Jul 19, 2021 •
edited
Loading

  • 保留原引用依赖的方法以提供引用旧版本 mirai 的方法
  • 考虑特殊引用情况（如直接引用 *-jvm / *-android ）
  • 确认不会强制引用 mirai-console
  • 本地无签名 publish 测试
  • 带签名 publish 测试

@Him188 Him188 modified the milestones: 2.9, 2.8-RC Jul 21, 2021
@Him188 Him188 self-requested a review July 21, 2021 05:56
@Him188
Copy link
Member

Him188 commented Sep 23, 2021

请不要使用 merge, 而是使用 rebase

Him188
Him188 reviewed Sep 23, 2021
View reviewed changes
@Him188 Him188 added the z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排 label Oct 5, 2021
@Him188 Him188 merged commit 8bd3d94 into mamoe:dev Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

@Karlatemp Karlatemp Karlatemp approved these changes

Assignees
No one assigned
Labels
t:feature 类型: 新特性 z:ready-to-merge 状态: PR 已经可以合并, 正在等待一些安排
Projects
None yet
Milestone
2.8.0-RC
Development

Successfully merging this pull request may close these issues.
4 participants
@AdoptOSS @Him188 @Karlatemp @ArcticLampyrid