Redesign notice handling and introduce NoticeProcessorPipeline
#1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karlatemp
reviewed
Jun 27, 2021
mirai-core/src/commonMain/kotlin/utils/io/serialization/utils.kt
Outdated
Show resolved
Hide resolved
| final override val asStranger: StrangerImpl by lazy { | ||
| Mirai.newStranger(this, StrangerInfoImpl(bot.id, bot.nick)).cast() | ||
| } | ||
| final override var nick: String by asFriend.info::nick |
There was a problem hiding this comment.
nick 在登录完成后会进行最后一次初始化校检, 使用的是 try-catch, 现在不是 lateinit var 了会导致最后的初始化校检不执行
There was a problem hiding this comment.
实际上 nick 应该不存在这种问题了 传过来的 tlv 会告诉你 nick，不过还是加上比较好
Him188
force-pushed
the
NoticeProcessorPipeline
branch
3 times, most recently
from
2b221b7 to
4e95154
Compare
This comment has been minimized.
This comment has been minimized.
Him188
force-pushed
the
NoticeProcessorPipeline
branch
2 times, most recently
from
329d7ec to
6e2d575
Compare
…nd` and `IMirai.newStranger`
Do not broadcast StrangerAddedEvent if added twice, fix stranger scope not closed Do not add new instance if there is already one Close and remove corresponding stranger instance if there is new friend.
Co-authored-by: Karlatemp <[email protected]>
- Extract `SyncController`; - Add super type `ProtocolStruct` to `ProtoBuf` and `JceStruct` to standardize `NoticeProcessorPipeline.process` - and other implementations for pipeline
Him188
force-pushed
the
NoticeProcessorPipeline
branch
from
e4a9440 to
65d6a08
Compare
- GroupRetrieveTest - GroupTransferTest - MemberAdminChangeTest - MemberQuitTest - MuteTest
Him188
force-pushed
the
NoticeProcessorPipeline
branch
from
65d6a08 to
70f2b04
Compare
Karlatemp
reviewed
Aug 30, 2021
mirai-core/src/commonMain/kotlin/network/notice/priv/FriendNoticeProcessor.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Karlatemp <[email protected]>
Him188
force-pushed
the
NoticeProcessorPipeline
branch
from
327f812 to
2cc101e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dump trashPacketFactory处理同步与解析等逻辑, 将结果提交给NoticeProcessorPipelineGroupListNoticeProcessor