Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirai-console 应允许插件使用 ktor，以向下兼容 #2297

Closed
Him188 opened this issue Oct 24, 2022 · 4 comments
Closed

mirai-console 应允许插件使用 ktor，以向下兼容 #2297

Him188 opened this issue Oct 24, 2022 · 4 comments
Labels
s:console 子系统: mirai-console t:task 类型: 要做的任务
Milestone
2.13.0

Comments

@Him188
Copy link
Member

Him188 commented Oct 24, 2022

如果插件不自己定义依赖，就让他 resolve 到 Ktor 1.6.7
@Him188 Him188 added t:task 类型: 要做的任务 s:console 子系统: mirai-console labels Oct 24, 2022
@Him188 Him188 added this to the 2.13.0 milestone Oct 24, 2022
@cssxsh
Copy link
Contributor

cssxsh commented Oct 24, 2022

我觉得应该 弄个类似 plugin-shared-libraries 的配置项
指定为某个插件注入特定版本的依赖，这样子比较好

@Him188
Copy link
Member Author

Him188 commented Oct 27, 2022

注入应该不好， @Karlatemp

@Karlatemp
Copy link
Member

应该在 plugin system 到 system classloader 中间再加一层 classloader

@cssxsh
Copy link
Contributor

cssxsh commented Oct 29, 2022

注入应该不好， @Karlatemp

这还可能方便处理统一日志框架的问题，比如将 slf4j 统一到某个版本，而不是各自为政

Him188 pushed a commit that referenced this issue Oct 31, 2022
@Karlatemp @Him188
[console] Add LegacyCompatibilityLayerClassLoader; Load ktor 1.6.8 …
e883a7c 
…as fallback; fix #2297

(cherry picked from commit d47221f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s:console 子系统: mirai-console t:task 类型: 要做的任务
Projects
None yet
Milestone
2.13.0
Development

No branches or pull requests
3 participants
@Him188 @Karlatemp @cssxsh