Bring back LanguagePluginInterface #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this maliit-server is unable to cast the language plugin causing a segfault rendering maliit-server non functional. This partly reverts commit 1e5aa06.
|
ping @jpetersen :) |
|
I do not see directly why it would crash without the patch, I will need another look. |
It fails to cast as it cant figure out the interface. It might be able to fudge it in other ways, but this fixed the issue we had on manjaro to get keyboard to load using maliit-server. It works using the built in keyboard binary. so problem is when it tries to load it as a plugin, where the interface is needed. |
|
Ok let us merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this maliit-server is unable to cast the language plugin causing
a segfault rendering maliit-server non functional.
This partly reverts commit 1e5aa06.