Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USE of AWS_PROFILE #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

USE of AWS_PROFILE #20

wants to merge 4 commits into from

Conversation

cell
Copy link

@cell cell commented Mar 2, 2020

Two behaviours adapted:

  • If AWS_PROFILE is set, it will be used as default value for the user/profile. Of course if the option -u is specified, its value is taken.
  • If a user/profile is given, be it by environment variable or argument, awsudo will use its value to set a new aws variable: AWS_PROFILE.

alecraso
alecraso reviewed Mar 2, 2020
View reviewed changes
Copy link

@alecraso alecraso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add tests?

@cell
Copy link
Author

cell commented Mar 29, 2020 •
edited
Loading

@aaronbiller It tooks some time but here are the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecraso alecraso alecraso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cell @alecraso