Add support for extended dependency names #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…face and package archives
Now we just need to write unit tests for our changes. A few of the unit tests are also failing currently, but we'll get those fixed up later before we merge.
hwittenborn
changed the title
hwittenborn
changed the title
We also fixed a bug while writing these unit tests. Guess they were well worth writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for extended dependency names to the generated package archives.
It also ensures that extended dependency names don't appear in the RPC interface, though this change brings about a deprecation notice for the RPC interface as well, in favor of only having the package archives.