-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark mode feature #26
Merged
hwittenborn
merged 23 commits into
makedeb:main
from
sumanbiswas7:sumanbiswas7/add-darkmode
Jun 3, 2023
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
01ff422
Add dark mode feature
sumanbiswas7 6b477e2
Change code background color
sumanbiswas7 746164d
ToggleTheme button update
sumanbiswas7 0c46ab3
Theme script seperated
sumanbiswas7 c401f8c
Clipboard icon and border color changes
sumanbiswas7 60432da
Post card date color changes
sumanbiswas7 407f769
Post hr color changes
sumanbiswas7 2d96ad6
Remove border of toggle thme button
sumanbiswas7 3021367
Toggle theme button icon, color changes
sumanbiswas7 8ea226f
Format JS/SCSS with Prettier
hwittenborn 203a57d
Fix GitHub CI config
hwittenborn 54fa82b
Refactor theme.js
sumanbiswas7 96b7aac
News/cards background color changes
sumanbiswas7 9f6dd44
Header background color changes
sumanbiswas7 f16a615
Move toggleTheme button to footer
sumanbiswas7 b51b9cb
Fix Merge Conflict
sumanbiswas7 ffaadbf
Remove optional chains
sumanbiswas7 f98b30d
Light color palette added
sumanbiswas7 792e29b
Run code through prettier
hwittenborn 16df8b0
Merge branch 'makedeb:main' into sumanbiswas7/add-darkmode
sumanbiswas7 a9f7d45
Duplace .themePostHrColor delete
sumanbiswas7 5ff1e3b
Add News Card dark mode border color
sumanbiswas7 a1697c1
Let's get this thing merged!
hwittenborn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: Run tests | ||
| on: [pull_request] | ||
| jobs: | ||
| run-tests: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout Git repository | ||
| uses: actions/checkout@v3 | ||
| - name: Install npm dependencies | ||
| run: npm install | ||
| - name: Make sure code is formatted | ||
| run: npx prettier --check . |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| # Hugo stuff. | ||
| /resources/_gen/ | ||
| resources/_gen/ | ||
| public | ||
| .hugo_build.lock | ||
|
|
||
| # NodeJS | ||
| node_modules/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| build | ||
| coverage | ||
| *.md | ||
| *.html | ||
| *.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "devDependencies": { | ||
| "prettier": "^2.8.4" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| .four-o-four { | ||
| padding: 2em 1em 0; | ||
| padding: 2em 1em 0; | ||
|
|
||
| p { | ||
| font-size: 2em; | ||
| text-align: center; | ||
| line-height: 1.3em; | ||
| } | ||
| p { | ||
| font-size: 2em; | ||
| text-align: center; | ||
| line-height: 1.3em; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,64 @@ | ||
| @import "variables"; | ||
|
|
||
| .content-section { | ||
| margin: 2em; | ||
|
|
||
| .header { | ||
| display: flex; | ||
| align-items: end; | ||
| padding-bottom: 1em; | ||
|
|
||
| h1 { | ||
| font-size: 2em; | ||
| padding-right: 0.3em; | ||
| } | ||
|
|
||
| .rss-icon { | ||
| color: darken($light-grey, 20%); | ||
| width: auto; | ||
| height: 1.4em; | ||
| transition-property: color; | ||
| transition-duration: 0.2s; | ||
| } | ||
|
|
||
| .rss-icon:hover { | ||
| color: $orange; | ||
| } | ||
| } | ||
|
|
||
| .post-card { | ||
| height: auto; | ||
| border: solid; | ||
| border-color: darken($silver, 10%); | ||
| border-width: 0.15em; | ||
| background-color: $silver; | ||
| border-radius: 0.2em; | ||
| padding: 1em 0.5em; | ||
| margin-bottom: 0.5em; | ||
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| .date { | ||
| font-size: 0.9em; | ||
| padding-bottom: 0.5em; | ||
| color: lighten($dark-grey, 40%); | ||
| } | ||
|
|
||
| .title { | ||
| font-size: 1.4em; | ||
| padding-bottom: 0.5em; | ||
| } | ||
|
|
||
| .title, .read-more { | ||
| color: $dark-grey; | ||
| transition: color 0.2s; | ||
| width: fit-content; | ||
| } | ||
|
|
||
| .title:hover, .read-more:hover { | ||
| color: $orange; | ||
| } | ||
| } | ||
| margin: 2em; | ||
|
|
||
| .header { | ||
| display: flex; | ||
| align-items: end; | ||
| padding-bottom: 1em; | ||
|
|
||
| h1 { | ||
| font-size: 2em; | ||
| padding-right: 0.3em; | ||
| } | ||
|
|
||
| .rss-icon { | ||
| color: darken($light-grey, 20%); | ||
| width: auto; | ||
| height: 1.4em; | ||
| transition-property: color; | ||
| transition-duration: 0.2s; | ||
| } | ||
|
|
||
| .rss-icon:hover { | ||
| color: $orange; | ||
| } | ||
| } | ||
|
|
||
| .post-card { | ||
| height: auto; | ||
| border: solid; | ||
| border-color: darken($silver, 10%); | ||
| border-width: 0.15em; | ||
| @extend .themeCardsColor; | ||
| border-radius: 0.2em; | ||
| padding: 1em 0.5em; | ||
| margin-bottom: 0.5em; | ||
| display: flex; | ||
| flex-direction: column; | ||
|
|
||
| .date { | ||
| font-size: 0.9em; | ||
| padding-bottom: 0.5em; | ||
| @extend .themePostContentDateColor; | ||
| } | ||
|
|
||
| .title { | ||
| font-size: 1.4em; | ||
| padding-bottom: 0.5em; | ||
| } | ||
|
|
||
| .title, | ||
| .read-more { | ||
| @extend .themeCardsColor; | ||
| transition: color 0.2s; | ||
| width: fit-content; | ||
| } | ||
|
|
||
| .title:hover, | ||
| .read-more:hover { | ||
| color: $orange; | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
border-colorhere is a bit too light on the dark theme (see the cards on/news) - could this be one of the theme-toggleable colors, with the dark theme having it set to something like#4d4d4d?