Checks to ReportViewer for export in file if that file already exists #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e name) Different localization for export dialog and patterns for filter by file type # Conflicts was: # RdlGtkViewer/RdlGtkViewer/ReportViewer.cs
Resolve conflict, duplicated </Project>
Gankov
requested changes
Sep 28, 2021
| fc.AddFilter(csvFilter); | ||
| } | ||
|
|
||
| if(!restrictedOutputPresentationTypes.Contains(OutputPresentationType.ExcelTableOnly)) { | ||
| Gtk.FileFilter excel2007Data = new Gtk.FileFilter { Name = "Excel no formatting (Fast)" }; | ||
| Gtk.FileFilter excel2007Data = new Gtk.FileFilter { Name = "Excel без форматирования (Быстро)" }; |
There was a problem hiding this comment.
Why this translation don't use resourses? Default language is English.
Gankov
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена кастомная проверка на существование файла с таким именем в директории при сохранении выгрузки
DoOverwrite не работала в данном случае, так как невозможно было присвоить имени файла необходимое расширение ДО выполнения процедуры проверки DoOverwriteConfirmation, следовательно процедура не замечает существования дубликата файла так как текущий сохраняемый файл не имеет расширения в своем имени
Также по задаче необходимо было изменить локализацию кнопок и заголовка, сделано это через ресурсы RdlEngine (чтобы не иметь кириллицы в коде проекта).
Для доступа к ресурсам из другого проекта пришлось модификаторы доступа ресурсов сделать public.