Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ember-getowner-polyfill into dependencies #806

Merged
merged 1 commit into from
Dec 14, 2015

Conversation

mike183
Copy link
Contributor

@mike183 mike183 commented Nov 30, 2015

Currently ember-getowner-polyfill is not being installed alongside ESA due to it being in the devDependencies rather than the regular dependencies. This resolves the issue.

@mike183
Copy link
Contributor Author

mike183 commented Nov 30, 2015

Test failure doesn't appear to be related to this change, all tests are passing locally. Can we try re-running the tests?

@mike183
Copy link
Contributor Author

mike183 commented Dec 14, 2015

ping @marcoow

@marcoow
Copy link
Member

marcoow commented Dec 14, 2015

👍

marcoow added a commit that referenced this pull request Dec 14, 2015
Move ember-getowner-polyfill into dependencies
@marcoow marcoow merged commit cfb9e1d into mainmatter:master Dec 14, 2015
@marcoow marcoow added this to the 1.x milestone Dec 14, 2015
@marcoow marcoow added bug and removed enhancement labels Dec 14, 2015
@mike183
Copy link
Contributor Author

mike183 commented Dec 14, 2015

Thank you 👍

@mike183 mike183 deleted the dependency-fix branch December 14, 2015 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants