-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude /fastboot-tests from npm #1470
Conversation
Nice, thanks. I think all of the other folders you mention should probably be excluded as well actually. |
Thought the same. The commented out lines came from #1389, so was not sure if there is same fancy stuff going on I don't understand!? 😉 I can update the PR if you don't see any reason to keep those... |
Oh, thanks for the hint. We do indeed need the tests as we’re deploying the dummy app to now.sh as the demo for the website. |
Ok, so I leave it like this. Not sure what Travis does not like though, certainly not related. Seems master is also failing in node4!? Btw, as I have you here... didn't have a chance to say thanks for EmberFest on the last evening, so... thanks! 😀 Was really a great event! |
Excluding
It looks like it's failing with Node 6 actually - I'll have a look.
Thank you for coming! Hope to see you there next year (and in Portland in March?) |
a5047d6
to
7c8e78f
Compare
done!
Sure, hope to make it! 👍 |
Tests should be fixed - can you rebase on |
7c8e78f
to
33b68e7
Compare
Done! |
thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Don't know about
/tests
, they seem to be included intentionally?Also was unsure about
docs
,guides
andserver
, which are all published, does that make sense?