Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude /fastboot-tests from npm #1470

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

simonihmig
Copy link
Contributor

Don't know about /tests, they seem to be included intentionally?

Also was unsure about docs, guides and server, which are all published, does that make sense?

@marcoow
Copy link
Member

marcoow commented Nov 9, 2017

Nice, thanks. I think all of the other folders you mention should probably be excluded as well actually.

@simonihmig
Copy link
Contributor Author

I think all of the other folders you mention should probably be excluded as well actually.

Thought the same. The commented out lines came from #1389, so was not sure if there is same fancy stuff going on I don't understand!? 😉

I can update the PR if you don't see any reason to keep those...

@marcoow
Copy link
Member

marcoow commented Nov 9, 2017

Oh, thanks for the hint. We do indeed need the tests as we’re deploying the dummy app to now.sh as the demo for the website.

@simonihmig
Copy link
Contributor Author

Ok, so I leave it like this. Not sure what Travis does not like though, certainly not related. Seems master is also failing in node4!?

Btw, as I have you here... didn't have a chance to say thanks for EmberFest on the last evening, so... thanks! 😀 Was really a great event!

@marcoow
Copy link
Member

marcoow commented Nov 10, 2017

Ok, so I leave it like this.

Excluding /docs and /guides should be fine - we only need /server and /tests so we can deploy the dummy app and the mock server to now.sh.

Not sure what Travis does not like though, certainly not related. Seems master is also failing in node4!?

It looks like it's failing with Node 6 actually - I'll have a look.

Btw, as I have you here... didn't have a chance to say thanks for EmberFest on the last evening, so... thanks! 😀 Was really a great event!

Thank you for coming! Hope to see you there next year (and in Portland in March?)

@simonihmig
Copy link
Contributor Author

Excluding /docs and /guides

done!

Hope to see you there next year (and in Portland in March?)

Sure, hope to make it! 👍

@marcoow
Copy link
Member

marcoow commented Nov 14, 2017

Tests should be fixed - can you rebase on master?

@simonihmig
Copy link
Contributor Author

Done!

@marcoow
Copy link
Member

marcoow commented Nov 14, 2017

thanks!

Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcoow marcoow merged commit 8a6bbb7 into mainmatter:master Nov 15, 2017
@simonihmig simonihmig deleted the update_npmignore branch March 12, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants