Improve OAuth2 implicit grant authenticator documentation #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
reviewed
Jun 8, 2017
| @@ -11,6 +11,10 @@ const { | |||
| ([RFC 6749](http://tools.ietf.org/html/rfc6749)), specifically the _"Implicit | |||
| Grant Type"_. | |||
|
|
|||
| Use {{#crossLink "OAuth2ImplicitGrantCallbackMixin"}}{{/crossLink}} in your | |||
| authentication/login route to parse authentication parameters from location | |||
There was a problem hiding this comment.
Should we say "OAuth 2.0 redirect route" or so here instead to be clearer?
There was a problem hiding this comment.
Great point, I'm going to make a change now.
alex-kovshovik
force-pushed
the
improve-implicit-grant-docs
branch
from
0d96c24 to
6dd7ba2
Compare
|
I made the suggested change. Thank you for the suggestion! |
marcoow
approved these changes
Jun 9, 2017
|
Awesome, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hint about
OAuth2ImplicitGrantCallbackMixinto theOAuth2ImplicitGrantAuthenticatordocumentation: to suggest built-in location string parsing.Also it fixes a typo.
This is continuation of #1353