Restore cookieExpirationTime from cookie value

[stevenwu]

When AdaptiveStore is using a CookieStore, the cookie values (name, domain, path) are only accessible through AdaptiveStore._cookies. I don't think they are restored, so proxyToInternalStore cannot access them. Do they need to be set in init as well?

/cc @marcoow

[marcoow]

Cool! I think we can actually simplify this a bit though as we can simply always override the expiration time with a value (potentially) read from a cookie.

[marcoow]

I don't think we need this here actually. When the cookie service is instantiated it will restore its own cookieExpirationTime from the cookie anyways.

[stevenwu]

I wasn't sure whether to add this, or change the test at https://github.com/simplabs/ember-simple-auth/pull/1257/files#diff-37b831f2713acdc8f0acf654aa735d70R310.

If the store is an Adaptive store, should we do something like

expect(store.get('_cookies.cookieExpirationTime')).to.equal(expirationTime);

?

[marcoow]

No, because the adaptive store's cookieExpirationTime property is already an alias for the underlying cookie store's cookieExpirationTime property anyway.

[stevenwu]

The test fails without this code. Maybe there's a bug elsewhere?

[marcoow]

I think we actually always want to override cookieExpirationTime. The idea here is that if you define your application session store as

export default Cookie.extend({
  cookieExpirationTime: 60 * 60
});

but then have a remember-me action in the UI that updates the expiration time like

rememberMe() {
  this.set('session.store.cookieExpirationTime', 60 * 60 * 24);
}

you'll want that value of 60 * 60 * 24 to be applied after the next reload although the initial value of 60 * 60 would be set in this case as well.

[marcoow]

Hm, there's only one thing that I just though of - if we always override the expiration time with the value restored from the cookie you could actually never change the expiration time later on.

[stevenwu]

If cookieExpirationTime is not set here, then it stays null because the setter in proxyToInternalStore is never called.

[marcoow]

Makes sense 👍