Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't return transitionTo from beforeModel #1247

Merged
merged 1 commit into from
Mar 8, 2017
Merged

don't return transitionTo from beforeModel #1247

merged 1 commit into from
Mar 8, 2017

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Mar 8, 2017 •
edited
Loading

This removes unnecessary returns from the AuthenticatedRouteMixin and UnauthenticatedRouteMixin mixins - there's basically no difference between return this.transitionTo(… and this.transitionTo(… in beforeModel anyway and the code currently is a bit confusing actually.

closes #1238

@marcoow marcoow requested a review from stevenwu March 8, 2017 17:05
stevenwu
stevenwu reviewed Mar 8, 2017
View reviewed changes
Copy link
Collaborator

@stevenwu stevenwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcoow
Copy link
Member Author

marcoow commented Mar 8, 2017

@stevenwu: can you approve via the Review UI if this is fine so we get the green check mark?

@marcoow marcoow merged commit ace86c8 into master Mar 8, 2017
@marcoow marcoow deleted the remove-unnecessary-return branch March 8, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenwu stevenwu stevenwu approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthenticatedRouteMixin
2 participants
@marcoow @stevenwu