-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ember import to torii authenticator #1216
Add Ember import to torii authenticator #1216
Conversation
Hm, failing tests - seem unrelated though… |
The tests have passed but the build failed because of this message:
Could you restart the build? |
The FastBoot tests are failing. This is consistent across all jobs so restarting will most likely not help… |
This PR should actually break this test but it seems like it's a different one that fails 😲 |
Indeed, sorry for being sloppy. I pushed the fix that made tests pass locally. FIngers crossed for Travis. |
BTW, how do you filter tests with |
I always ran all of the node tests - no idea how to filter them actually ;) |
It seems like the tests haven't rerun after I added my second commit. |
@balinterdi: I restarted the build manually |
f53446d
to
0fbb9c3
Compare
@balinterdi: you had pushed a modified |
I rebased commits and removed the |
Ah, that explains it, thanks! |
A jshint/eslint error was thrown after generating an authenticator that extends the torii one:
This PR adds the missing line.