Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ember import to torii authenticator #1216

Merged

Conversation

balinterdi
Copy link
Contributor

A jshint/eslint error was thrown after generating an authenticator that extends the torii one:

ember g authenticator github-auth-code --base-class=torii

This PR adds the missing line.

@marcoow
Copy link
Member

marcoow commented Feb 13, 2017

Hm, failing tests - seem unrelated though…

@balinterdi
Copy link
Contributor Author

The tests have passed but the build failed because of this message:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Could you restart the build?

@marcoow
Copy link
Member

marcoow commented Feb 13, 2017

The FastBoot tests are failing. This is consistent across all jobs so restarting will most likely not help…

@marcoow
Copy link
Member

marcoow commented Feb 13, 2017

This PR should actually break this test but it seems like it's a different one that fails 😲

@balinterdi
Copy link
Contributor Author

Indeed, sorry for being sloppy. I pushed the fix that made tests pass locally. FIngers crossed for Travis.

@balinterdi
Copy link
Contributor Author

BTW, how do you filter tests with npm test? I haven't found anything that works and thus needed to run the whole suit.

@marcoow
Copy link
Member

marcoow commented Feb 14, 2017

I always ran all of the node tests - no idea how to filter them actually ;)

@balinterdi
Copy link
Contributor Author

It seems like the tests haven't rerun after I added my second commit.

@marcoow
Copy link
Member

marcoow commented Feb 14, 2017

@balinterdi: I restarted the build manually

@marcoow marcoow force-pushed the add-ember-import-to-torii-authenticator branch from f53446d to 0fbb9c3 Compare February 14, 2017 19:25
@marcoow
Copy link
Member

marcoow commented Feb 14, 2017

@balinterdi: you had pushed a modified bower.json as well - I assume that's what broke the build.

@marcoow marcoow added this to the 1.3 milestone Feb 14, 2017
@marcoow marcoow merged commit 50fd263 into mainmatter:master Feb 14, 2017
@balinterdi
Copy link
Contributor Author

@marcoow Oops, sorry about that. I see the bower.json change locally but not in the PR, which is interesting.

I saw you merged it (thank you), so is everything good now?

@marcoow
Copy link
Member

marcoow commented Feb 15, 2017

I rebased commits and removed the bower.json - everything fine now 🎉

@balinterdi
Copy link
Contributor Author

Ah, that explains it, thanks!

@marcoow marcoow modified the milestones: 1.3, 1.2.1 Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants