Override headersForRequest (with tests) #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also relocates headersForRequest closer to its older equivalent, ajaxOptions
| Adds request headers containing the authorization data as constructed | ||
| by the {{#crossLink "DataAdapterMixin/authorizer:property"}}{{/crossLink}}. | ||
|
|
||
| This method will only called in Ember Data 2.7 or greater, older versions |
There was a problem hiding this comment.
This method will only *be* called in Ember Data 2.7 or greater, older versions ;)
There was a problem hiding this comment.
Can you tell I've had 4hrs of sleep today 😉
|
Looks good! Left some comments on minor assertion-style things. |
|
@marcoow should be good to go! |
bakerac4
pushed a commit
to bakerac4/ember-simple-auth
that referenced
this pull request
Sep 8, 2016
* Override headersForRequest, fixes mainmatter#1003 * Test headersForRequest, assert authorizer presence Also relocates headersForRequest closer to its older equivalent, ajaxOptions * Test for when Adapter doesn't have headersForRequest * Better English, remove redundant test assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original work completed by @JeroenvdV in #1009, but now with tests and asserting authorizer presence.
This attempts to fix #1003 so Ember Data 2.7 and greater can send authorization header data when using
DataAdapterMixin.@marcoow let me know if this test coverage is sufficient!