Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataAdapterMixin error invalidating session if not yet authenticated #721

Closed
wireframe opened this issue Oct 16, 2015 · 0 comments
Closed

DataAdapterMixin error invalidating session if not yet authenticated #721

wireframe opened this issue Oct 16, 2015 · 0 comments

Comments

@wireframe
Copy link
Contributor

This error is raised from the DataAdapterMixin if the server returns a 401 request and the session has not been authenticated yet.

Uncaught Error: Assertion Failed: Session#invalidate requires the session to be authenticated!

This is a fatal error that prevents Ember from transitioning to the error route.
wireframe added a commit to wireframe/ember-simple-auth that referenced this issue Oct 16, 2015
@wireframe
Only invalidate session if authenticated
fe3ffd8 
Fix mainmatter#721

Also update method to return `DS.InvalidError` as recommended in ember data documentation.
https://github.com/emberjs/data/blob/ffb24c5c745023fa8d5168ec6aa53051a6609751/packages/ember-data/lib/adapters/rest-adapter.js#L729-L734
@wireframe wireframe mentioned this issue Oct 16, 2015
Merged
wireframe added a commit to wireframe/ember-simple-auth that referenced this issue Oct 19, 2015
@wireframe
Only invalidate session if authenticated
6a09e70 
Fix mainmatter#721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wireframe