Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register in cli and ci #2694

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Register in cli and ci #2694

merged 4 commits into from
Feb 3, 2025

Conversation

grumbach
Copy link
Member

@grumbach grumbach commented Feb 3, 2025 •
edited
Loading

  • CLI registers integration matching previous API known to users
  • Tests to prove and verify they work in CI
  • Add registers in Vault's user data so folk don't need to keep ANY extra key at all for registers

cc: @happybeing

@grumbach grumbach force-pushed the register_in_cli_and_ci branch from 86ec07e to 5ad8270 Compare February 3, 2025 04:18
@grumbach grumbach enabled auto-merge February 3, 2025 04:45
mickvandijke
mickvandijke approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@mickvandijke mickvandijke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

@grumbach grumbach added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@grumbach grumbach added this pull request to the merge queue Feb 3, 2025
Merged via the queue into maidsafe:main with commit 4d9da49 Feb 3, 2025
25 checks passed
@grumbach grumbach deleted the register_in_cli_and_ci branch February 3, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maqi maqi maqi approved these changes

@mickvandijke mickvandijke mickvandijke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grumbach @maqi @mickvandijke