feat: add NodeSpawner and NetworkSpawner
#2642
Conversation
mickvandijke
force-pushed
the
feat-node-from-code
branch
from
451f342 to
e6a4fc5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /// Once a node is started and running, the user obtains | ||
| /// a `NodeRunning` object which can be used to interact with it. | ||
| #[derive(Clone)] | ||
| pub struct RunningNode { | ||
| shutdown_sender: watch::Sender<bool>, |
There was a problem hiding this comment.
We send TerminateNode(String) via the NodeEventsChannel below, can this be re-used here?
There was a problem hiding this comment.
It could be reused for the node (NodeEvents) loop, but for the SwarmDriver loop it wouldn't make sense, as the broadcast channel uses ant_node::event::NodeEvent, which is inaccessible from the ant-networking crate in which the SwarmDriver loop resides.
mickvandijke
force-pushed
the
feat-node-from-code
branch
from
fbfd2a0 to
c8909d6
Compare
mickvandijke
force-pushed
the
feat-node-from-code
branch
from
bcef93e to
17b0f20
Compare
mickvandijke
force-pushed
the
feat-node-from-code
branch
from
66e4e9a to
73f902b
Compare
| @@ -280,10 +285,15 @@ | |||
| // TODO: Think about handling the mDNS error here. | |||
| let (network, event_receiver, swarm_driver) = network_builder.build_client(); | |||
|
|
|||
| let _swarm_driver = ant_networking::time::spawn(swarm_driver.run()); | |||
| // TODO: Implement graceful SwarmDriver shutdown for client. | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
There was a problem hiding this comment.
for the files under the spawn, as the file names of network.rs and node.rs is very similar to the existing Node Network, can they be renamed to network_spawner.rs node_spawner.rs` to match the struct names ?
Also, seems the functions within the NetworkSpawner and NodeSpawner are very much similar to the existing ones, for example ant_node\src\bin\antnode\main.rs::create_secret_key_file
I am wondering why there is new duplicated functions as well?
It seems NetworkSpawner and NodeSpawner are two utility wrapping struct, which seems the PR title is bit misleading.
Shall the PR Title change to: Add NodeSpawner and NetworkSpawner ?
Ah yes, great suggestion!
Functions like
Sure, makes sense! |
mickvandijke
changed the title
NodeSpawner and NetworkSpawner
REQUIRES mDNS REMOVAL PR: #2652
Adds the option to spawn nodes and networks from code using
NodeSpawnerandNetworkSpawner.TODO: