feat(network): introduce relay reservation score #2634
Conversation
This should have been collected yesterday, but was forgotten.
…entt feat(metrics): implement custom relay client metrics
…_on_restart fix(network): set the record count metric as soon as we restart
…l addr are private
…or_fix fix(network): consider MultiAddrNotSupported as a serioud issu..
ant-networking/src/relay_manager.rs
Outdated
| } | ||
|
|
||
| for from_peer in to_remove { | ||
| debug!("Removing {from_peer:?} from the incoming_connections_from_remote_peer"); |
There was a problem hiding this comment.
incoming_connections_from_remote_peer only got pruned when got updated within above block of code
what if entries remained in the container due to some bug/error, which makes it growing infinitely ?
There was a problem hiding this comment.
The only scenario where this can happen is from the below code
let Some(latest_time) = connections.iter().map(|(_, _, time, _)| time).max() else {
debug!("The incoming connections from {from_peer:?} are empty. Skipping.");
continue;
};
let Ok(elapsed) = SystemTime::now().duration_since(*latest_time) else {
debug!("Could not obtain elapsed time.");
continue;
};
This can only happen if there is a bug in our code. The cleanup does not depend on the events, it depends on just the MAX_DURATION_TO_TRACK_INCOMING_CONNECTIONS_PER_PEER.
Just depending on a timer is fine because a connection cannot take more than 15s before a ConnectionEstablished or a IncomingConnectionError is emitted tbh.
There was a problem hiding this comment.
ok. fine then.
just This can only happen if there is a bug in our code could happen
RolandSherwin
force-pushed
the
relay_healthh
branch
4 times, most recently
from
4f71cc1 to
f7b3521
Compare
jacderida
force-pushed
the
relay_healthh
branch
from
ea86a05 to
a3f5d72
Compare
RolandSherwin
force-pushed
the
relay_healthh
branch
2 times, most recently
from
fa17cbc to
bc9fad6
Compare
RolandSherwin
force-pushed
the
relay_healthh
branch
from
bc9fad6 to
820b92b
Compare
|
superseded by #2691 |
This PR will now also merge #2617, #2618 and #2628 from the hotfix branch that was not released.