-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade 0ver to Python 3.13, add GitHub Actions, and other QoL improvements #227
Conversation
I'd love to update the README in this PR if I can get a better understanding of the process. |
Hehe, yeah, apologies for the dearth of documentation. This was an April Fools' joke that got a lot more traction than expected 😅 Nothing we can't fix though! These are good starting questions. Release processI'm on Ubuntu 22.04, using Python 3.10 (the default I think).
ChertChert's a static site generator I use for 0ver, calver, and my blog. I pip install it from the github repo. The PyPI version may be out of date. It definitely runs on Python 3.10 at least. rsync is only necessary for the publish, local rendering and serving have been tested on Mac/Windows in the past. CIGitHub Actions all the way. Would ideally love to never speak of Travis again (they got bought by private equity and the rest is history). LinterI'd be fine with Ruff, though it's really just one Python file for 0ver. I "lint" the YAML of other projects with a custom command, but that's a little more work. ConfigWhich configuration vars were you thinking about? I only use the env vars for github auth. When only dealing with a couple of params, it's often easier that way. Chert itself also has a config, in chert.yaml. |
The linting and config questions were related to the modules in the |
Well, I do use one script in |
Sweet, I got nothing better to do over the holidays XD |
What is |
chert feature, gives you hooks to modify posts. here's the relevant chert code. In zerover, it's used to pull in the lists from the JSON files, turn them into the tables that constitute our walls of shame/fame. |
I was able to install Chert from the repository. I fixed a couple errors from the newer Python 3.13 version and am working on a problem with the UPDATE: |
Test projects validation workflow v2
Test CI v3
@mahmoud Want to take a look at the new workflow and let me know what you think? I would also love to know what to fill out for the |
Also, there are several pull requests and issues that can be merged and closed. |
I only found those 2 and the caching one. I was just thinking that a config file is more cross-compatible because commands like |
A super easy way to use this is Simply create a .env file, then at the top of the Python script, call UPDATE: I added this in the latest commit, lmk what you think. |
Working on a really cool system to add after this PR... Related to #236 |
Lol, I love https://github.com/MaskRay/ccls 's spin on 0ver |
Haha, CalVer and 0ver, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! A few comments on the approach, but I think this is getting quite close.
Co-authored-by: Mahmoud Hashemi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing a closer read of the CI, I think I spotted some issues.
And we're merged! This was awes0me, looking forward to the next! |
OK knocked out a few bugs and now there's just the workflow / commit back bit that's not happy: https://github.com/mahmoud/zerover/actions/runs/12578454094/job/35057198438 Otherwise, looking good! |
I'll look into this 👍 |
And there it is, like magic: 5ab8308 |
Haha, looks like merging multiple PRs at once exhausts the request limit and fails the parallel actions. A few fixes come to mind:
Just brainstorming. If any of these appeal, feel free to create an issue/PR. |
Greta ideas! I honestly love all of them. I'll do some thinking and probably do some work in another PR. Can you convert that comment into an issue? |
Closes #169, closes #185, closes #225, closes #228, and closes #233
Summary
This PR accomplishes several things.
projects.yaml
providing a number of changes and fixes. See here.gh_url
key. This allows you to specify the correctfirst_version
if it isn't tagged on GitHub.README.md
to provide contributors with a more detailed guide.After Merge
After merging this PR, @mahmoud will need to
README.md
for more information.TODO Before Merge
projects.json
for validity @MattTheCuberOriginal PR questions
So, I thought this wouldn't be too bad, but now I am just really confused. I compiled a list of questions below:ANSWERS: #227 (comment)