Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account multiple Set-Cookie headers in logDebugResponseCookie #326

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Take into account multiple Set-Cookie headers in logDebugResponseCookie #326

merged 1 commit into from
Dec 9, 2016

Conversation

kaaloo
Copy link
Contributor

@kaaloo kaaloo commented Dec 8, 2016

While investigating a lost session on login issue, I came across this issue in trace level debugging. Our app which uses Apache Shiro is currently sending out two Set-Cookie headers, one for deleting a remember me cookie and one for setting the JSESSIONID. The current code doesn't always emit a log entry in logDebugResponseCookie presumably because which of these headers is actually processed is non-deterministic. This small patch will go through all Set-Cookie headers and emit a log entry for each session cookie.

@magro magro merged commit 647f121 into magro:master Dec 9, 2016
@magro
Copy link
Owner

magro commented Dec 9, 2016

Thanks for the PR! How urgent is a release for you?

@kaaloo
Copy link
Contributor Author

kaaloo commented Dec 28, 2016

Sorry for the long delay! Just getting to this during the holidays. There is no urgency, we are using a patched jar. Thanks for asking!

magro pushed a commit that referenced this pull request Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants