Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of VAT on FPT Surcharge deduction #231

Closed
rhengeveldbordex opened this issue Aug 15, 2024 · 9 comments
Closed

Incorrect handling of VAT on FPT Surcharge deduction #231

rhengeveldbordex opened this issue Aug 15, 2024 · 9 comments
Assignees
Labels
Fixed and planned for next release Fix will be included in the next release.
Milestone

Comments

@rhengeveldbordex
Copy link

There appears to be a discrepancy in how the Fixed Product Tax (FPT) surcharge is handled when processing orders from external marketplaces. Specifically, the VAT on the FPT surcharge is not being correctly subtracted from the product price, leading to a mismatch in the order totals (Magento <-> Marketplace).

Steps to Reproduce
Internal Order Configuration:

Subtotal (Excl. FPT and VAT): €72.10
FPT (Excl. VAT): €6.56
Grand Total (Excl. VAT): €78.66
VAT (21%): €16.52
Grand Total (Incl. VAT): €95.18

Marketplace Order Configuration:

Order Total (Incl. VAT): €93.80

Expected Behavior:

The product price on the marketplace should have the FPT surcharge correctly subtracted, ensuring that the internal and external order totals match (both should be €93,80).

Actual Behavior:

The VAT on the FPT surcharge is not correctly subtracted. This results in an incorrect product price being calculated, leading to a difference between the marketplace order total (€93.80) and the Magento order total (€95.18).

Analysis
It looks like the issue occurs because the VAT on the FPT surcharge (€1.38) is not being correctly handled during the deduction process. This leads to an incorrect calculation of the product price in Magento.

@Frank-Magmodules
Copy link
Member

Hi There @rhengeveldbordex,
Thanks for bringing this issue to our attention. I’m working on reproducing it now and will get back to you shortly.

@Frank-Magmodules Frank-Magmodules self-assigned this Aug 16, 2024
@Frank-Magmodules Frank-Magmodules added the Investigating We are working on this issue together with the customer. label Aug 16, 2024
@Frank-Magmodules
Copy link
Member

Hi @rhengeveldbordex,

I wasn't able to reproduce the issue on my end using the import simulator and your data. Could you please contact us directly so we can check this on your development/staging environment if possible?

Thanks a lot!

@Frank-Magmodules
Copy link
Member

Hi @rhengeveldbordex, We haven’t received any updates from you on this issue yet. Is it still relevant, and can we assist you further? Feel free to reach out, and we’ll be happy to take a look with you.

@Frank-Magmodules
Copy link
Member

Hi @rhengeveldbordex,

We’ve pushed a fix to this branch: https://github.com/magmodules/magento2-channable/tree/release/1.20.0. It appears that this issue only occurs when recalculating prices on products (specifically when prices are set as excluding tax in the Magento admin).

Could you let us know your findings?
If everything meets your requirements, we’ll proceed with pushing this to an official release!

@Frank-Magmodules Frank-Magmodules added Question / Issue Further information is requested and removed Investigating We are working on this issue together with the customer. labels Oct 9, 2024
@rhengeveldbordex
Copy link
Author

Hi @Frank-Magmodules,

Thanks for the update! I appreciate the quick fix. I will test the changes and provide feedback shortly. From the initial review, it looks promising. If there are any issues, I'll let you know. Otherwise, it seems good to go for an official release!

@Marvin-Magmodules Marvin-Magmodules added Fixed and planned for next release Fix will be included in the next release. and removed Question / Issue Further information is requested labels Nov 13, 2024
@Marvin-Magmodules Marvin-Magmodules added this to the v1.20.0 milestone Nov 13, 2024
@mikemoooo
Copy link

Hey @Frank-Magmodules ,
Do you know when the 1.20 update will be released?
We would need this fix for calculation as well.
Cheers,
Mike

@rhengeveldbordex
Copy link
Author

Hi Frank,

Just a quick update from our side. We are now on the branch with the fix for this issue. We're no longer experiencing any problems, so as far as we're concerned, it can be included in the next release.

@Frank-Magmodules
Copy link
Member

Perfect, @rhengeveldbordex! Thank you for confirming this. We’ll update the issue as soon as the release is live!

@Frank-Magmodules
Copy link
Member

Frank-Magmodules commented Jan 9, 2025

Hi All!

I’m happy to announce that we’ve just released our new 1.20.0 version, which finally addresses VAT calculations in combination with FPT.

I’ll be closing this ticket for now, but feel free to reopen it or leave a comment if there’s anything else you need.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed and planned for next release Fix will be included in the next release.
Projects
None yet
Development

No branches or pull requests

4 participants