Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty parentRelations fallback returns full product collection #222

Closed
rexterkate-adwise opened this issue Apr 9, 2024 · 2 comments
Closed
Assignees
Labels
Question / Issue Further information is requested

Comments

@rexterkate-adwise
Copy link

Hi,

the getParents function in Model/Collection/Products.php has a fallback when the parentRelations are empty, it returns $this->productCollection.

This should return an empty collection (according the comment), but it returns the full product collection without filtering instead.

We are running into performance problems because of of this with a webshop with a rather large amount of products

@Frank-Magmodules
Copy link
Member

Hi there @rexterkate-adwise, thank you for reaching out!
Could you please contact us directly so that we can further investigate this issue together?

@Frank-Magmodules
Copy link
Member

Hello @rexterkate-adwise, again, i appreciate you bringing this issue to our attention.

I'm happy to inform you that we've released a new version of the plugin addressing the reported issue. Since I believe this update resolves your concern, I'm closing the issue for now.

However, please don't hesitate to reopen or comment if you find further issues or have any additional feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question / Issue Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants