Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash to core extensions #399

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Add hash to core extensions #399

merged 1 commit into from
Apr 21, 2023

Conversation

cedric-anne
Copy link
Contributor

As of PHP 7.4.0, the Hash extension is a core PHP extension, so it is always enabled.

see https://www.php.net/manual/en/hash.installation.php

@cedric-anne cedric-anne mentioned this pull request Apr 21, 2023
Closed
@cedric-anne cedric-anne changed the base branch from 4.6.x to 4.5.x April 21, 2023 09:35
@cedric-anne
Copy link
Contributor Author

I set 4.5.x as target as I think it can be considered as a bug.

@Ocramius Ocramius changed the base branch from 4.5.x to 4.6.x April 21, 2023 21:06
@Ocramius Ocramius added this to the 4.6.0 milestone Apr 21, 2023
@Ocramius Ocramius self-assigned this Apr 21, 2023
Ocramius
Ocramius approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the target branch to 4.6.x:

  • the patch wasn't based on the bugfix branch, so it was a bit noisy
  • this is pretty much an improvement: upgrading to 4.6.0 should be a no-brainer for consumers anyway

@Ocramius Ocramius merged commit a5d4951 into maglnet:4.6.x Apr 21, 2023
@cedric-anne cedric-anne deleted the fix/hash-core-extension branch April 22, 2023 08:31
@AdrienClairembault AdrienClairembault mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cedric-anne @Ocramius