🐛 Fix unity code stripping for KeyStore #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks @nicoeft |
Pull Request Test Coverage Report for Build 5056354939
💛 - Coveralls |
xiaolou86
pushed a commit
to xiaolou86/Solana.Unity-Core
that referenced
this pull request
Oct 12, 2023
* ✨ Add XNFT Wallet + xNFT WebGLTemplate - Add XNFTWallet to Runtime codebase and related xNFT js lib to Runtime plugins. - WebGLTemplates folder with xNFT template to be used when building for xNFT - Comments showing how to use it in LoginScreen.cs * Added WebGLTemplatesExporter + LoginXNFT Button Prefab * ♻️ Add copy/paste & refactor backpack code * ✨ Add XNFT Wallet + xNFT WebGLTemplate (magicblock-labs#31) * ✨ Add XNFT Wallet + xNFT WebGLTemplate - Add XNFTWallet to Runtime codebase and related xNFT js lib to Runtime plugins. - WebGLTemplates folder with xNFT template to be used when building for xNFT - Comments showing how to use it in LoginScreen.cs * Added WebGLTemplatesExporter + LoginXNFT Button Prefab * ➕ Add missing script * ✨ Update template * 🙈 Update n.pmignore * 📄 Update License * ♻️ Add license meta * 🎨 Improve link UI * 🎨 Improve scene Co-authored-by: Nicolas Francisquelo Tacca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In Game Wallet Login not working in WebGL
Solution
Prevent Unity to strip code from KeyStore. EncryptedKeystoreJson was invalid and that made login fail
Before & After Screenshots
BEFORE:
Deploy Notes
Need to build .dll and publish to Solana.Unity-SDK