Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:Fix: transactions populated from RPC requests retain original accounts order #27

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

GabrielePicco
Copy link
Contributor

Fix transactions populated from RPC requests retain original accounts order

Status Type ⚠️ Core Change Issue
Ready Bug No -

Problem

transactions populated from RPC requests retain original accounts order

Solution

use the original order if the transaction was deserialized

Before & After Screenshots

Insert screenshots of example code output

BEFORE:
[insert screenshot here]

AFTER:
[insert screenshot here]

Other changes (e.g. bug fixes, small refactors)

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc.

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

@GabrielePicco GabrielePicco merged commit 81ecc9a into master Mar 22, 2023
@GabrielePicco GabrielePicco deleted the fix/transaction-builder branch March 22, 2023 07:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4487508010

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 73.305%

Totals Coverage Status
Change from base Build 4317166259: 0.09%
Covered Lines: 4726
Relevant Lines: 6147

💛 - Coveralls

xiaolou86 pushed a commit to xiaolou86/Solana.Unity-Core that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants