Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Improve Dex transaction API & Bug Fix #22

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

GabrielePicco
Copy link
Contributor

Simplify and enhance the Orca DEX API

Status Type ⚠️ Core Change Issue
Ready Enhance & Bug No

Solution

  • Simplify the Dex interface
  • Fix bug for native swap

@GabrielePicco GabrielePicco force-pushed the enhance/dex-implementation branch from 0836f35 to 5dd87f7 Compare January 18, 2023 13:57
@coveralls
Copy link

coveralls commented Jan 18, 2023

Pull Request Test Coverage Report for Build 3957282303

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 32 (18.75%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 80.314%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Solana.Unity.Extensions/TokenMintResolver.cs 0 3 0.0%
src/Solana.Unity.Rpc/Utilities/RuntimePlatforms.cs 5 14 35.71%
src/Solana.Unity.Rpc/Core/Http/CrossHttpClient.cs 1 15 6.67%
Files with Coverage Reduction New Missed Lines %
src/Solana.Unity.Extensions/TokenMintResolver.cs 1 77.46%
src/Solana.Unity.Rpc/Core/Http/CrossHttpClient.cs 1 10.26%
Totals Coverage Status
Change from base Build 3932339694: -0.2%
Covered Lines: 5122
Relevant Lines: 6125

💛 - Coveralls

@GabrielePicco GabrielePicco merged commit d428f0d into master Jan 19, 2023
@GabrielePicco GabrielePicco deleted the enhance/dex-implementation branch January 19, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants