Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude all builtin modules #343

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: exclude all builtin modules #343

merged 1 commit into from
Aug 14, 2024

Conversation

smeijer
Copy link
Member

@smeijer smeijer commented Aug 14, 2024

This makes sure that all native node modules are seen as external (not excluded in the bundle) and thereby fixes the TypeError: assert.equal is not a function, which was caused by signalExit (which is included by configstore)

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 2:12pm

Copy link

pkg-pr-new bot commented Aug 14, 2024

commit: def9c54

@magicbell/cli

yarn add https://pkg.pr.new/@magicbell/cli@343

@magicbell/core

yarn add https://pkg.pr.new/@magicbell/core@343

@magicbell/embeddable

yarn add https://pkg.pr.new/@magicbell/embeddable@343

@magicbell/in-app

yarn add https://pkg.pr.new/@magicbell/in-app@343

magicbell

yarn add https://pkg.pr.new/magicbell@343

@magicbell/magicbell-react

yarn add https://pkg.pr.new/@magicbell/magicbell-react@343

@magicbell/react-headless

yarn add https://pkg.pr.new/@magicbell/react-headless@343

@magicbell/user-client

yarn add https://pkg.pr.new/@magicbell/user-client@343

@magicbell/webpush

yarn add https://pkg.pr.new/@magicbell/webpush@343

Open in Stackblitz

@smeijer smeijer merged commit c876c93 into main Aug 14, 2024
8 checks passed
@smeijer smeijer deleted the feature/fix-cli-bundle branch August 14, 2024 14:48
@MagicBella MagicBella mentioned this pull request Aug 12, 2024
smeijer pushed a commit that referenced this pull request Aug 14, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @magicbell/[email protected]

### Patch Changes

- [#343](#343)
[`c876c93`](c876c93)
Thanks [@smeijer](https://github.com/smeijer)! - ensure all native node
modules are excluded from the bundle

## @magicbell/[email protected]

### Patch Changes

- Updated dependencies
\[[`604cce2`](604cce2)]:
    -   @magicbell/[email protected]

## @magicbell/[email protected]

### Patch Changes

-
[`ec38aee`](ec38aee)
Thanks [@renovate\[bot\]](https://github.com/renovate%5Bbot%5D)! -
Updated dependencies:

    -   updated `lit` to `^3.2.0`.

- [#338](#338)
[`640c42c`](640c42c)
Thanks [@renovate](https://github.com/apps/renovate)! - Updated
dependencies:

    -   updated `@custom-elements-manifest/analyzer` to `^0.10.3`.

## @magicbell/[email protected]

### Patch Changes

-
[`604cce2`](604cce2)
Thanks [@renovate\[bot\]](https://github.com/renovate%5Bbot%5D)! -
Updated dependencies:

    -   updated `@babel/core` to `^7.25.2`.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant