-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract the plist via ASN1 parser #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Works as expected and is much nicer this way! 👏
Could you add a changeset via yarn && yarn changeset
please? That way the change will be attibuted to you. I think a patch level change should be enough, as no API changes occured.
// import Security | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like some leftover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have some code to check the code signing certificate to see if it's a testflight build - but I left that out for now.
I can try. Never used that before. Would be good to give some more instructions in the |
@tcurdt I'll make sure to provide more on how to use changesets. I'll add one for this PR myself and will tag you as a contributor. Thank's for your time amnd effort. Don't want to keep you busy any longer and will merge the PR now. 🙌 |
Co-authored-by: Torsten Curdt <[email protected]>
Change description
Parse the provisioning profile (properly) to extract the plist.
Added an ASN1 parser as dependency.
Test Plan
The same tests are still passing.
Type of Change
Guidelines