Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract the plist via ASN1 parser #4

Merged
merged 6 commits into from
Oct 21, 2024
Merged

extract the plist via ASN1 parser #4

merged 6 commits into from
Oct 21, 2024

Conversation

tcurdt
Copy link
Contributor

@tcurdt tcurdt commented Oct 19, 2024

Change description

Parse the provisioning profile (properly) to extract the plist.
Added an ASN1 parser as dependency.

Test Plan

The same tests are still passing.

Type of Change

  • Bug fix
  • Feature
  • Enhancement

Guidelines

  • A changeset is included, or the change is not noteworthy enough to warrant one

Copy link
Member

@stigi stigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works as expected and is much nicer this way! 👏

Could you add a changeset via yarn && yarn changeset please? That way the change will be attibuted to you. I think a patch level change should be enough, as no API changes occured.

Comment on lines +4 to +5
// import Security

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like some leftover

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have some code to check the code signing certificate to see if it's a testflight build - but I left that out for now.

Package.swift Show resolved Hide resolved
@tcurdt
Copy link
Contributor Author

tcurdt commented Oct 21, 2024

Could you add a changeset via yarn && yarn changeset please?

I can try. Never used that before.

Would be good to give some more instructions in the contribution.md.
Even this https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md does not feel good enough.

@stigi
Copy link
Member

stigi commented Oct 21, 2024

@tcurdt I'll make sure to provide more on how to use changesets. I'll add one for this PR myself and will tag you as a contributor. Thank's for your time amnd effort. Don't want to keep you busy any longer and will merge the PR now. 🙌

@stigi stigi merged commit 1ff182c into magicbell:main Oct 21, 2024
1 check passed
stigi added a commit that referenced this pull request Oct 21, 2024
Co-authored-by: Torsten Curdt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants