Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA#3093 Url Rewrite to external URL does not work on PWA #4109

Merged
merged 3 commits into from
May 24, 2023

Conversation

RaghavendraTirumalasetti
Copy link
Contributor

Description

Magento allows you to create Url Rewrites to external urls. Example test-url -> www.google.com. If you try to access www.magento-store.com/test-url you'll be redirected to google as intended. This was not working on GraphQl but it was fixed on https://jira.corp.adobe.com/browse/ACP2E-1494

If you apply the changes made by L3 to the api, the URL redirect will still not work on PWA even if GraphQL sends the correct redirect information.

This bug is preventing PWA stores from using redirects to external urls.

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3093.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Apr 27, 2023

Messages
📖

Associated JIRA tickets: ACP2E-1494.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 52e51ad

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 7d99f87

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 7d99f87

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label May 24, 2023
@glo82145
Copy link
Collaborator

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 24, 2023

Successfully started codebuild job for lighthouse-mobile

@glo82145
Copy link
Collaborator

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented May 24, 2023

Successfully started codebuild job for lighthouse-desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants