PWA-3034: lighthouse mobile home page accessibility scored reduced to…

… 98 (#4011) - Add aria label to carousel gallery item links - fix console warning for tabIndex
magento · Dec 1, 2022 · f285ea2 · f285ea2
1 parent 5afac23
commit f285ea2
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/packages/venia-ui/lib/components/CategoryTree/categoryBranch.js b/packages/venia-ui/lib/components/CategoryTree/categoryBranch.js
@@ -46,5 +46,5 @@ Branch.propTypes = {
         text: string
     }),
     setCategoryId: func.isRequired,
-    tabIndex: func.isRequired
+    tabIndex: string
 };
diff --git a/packages/venia-ui/lib/components/CategoryTree/categoryLeaf.js b/packages/venia-ui/lib/components/CategoryTree/categoryLeaf.js
@@ -56,6 +56,6 @@ Leaf.propTypes = {
         text: string
     }),
     onNavigate: func.isRequired,
-    tabIndex: func.isRequired,
+    tabIndex: string,
     categoryUrlSuffix: string
 };
diff --git a/packages/venia-ui/lib/components/CategoryTree/categoryTree.js b/packages/venia-ui/lib/components/CategoryTree/categoryTree.js
@@ -66,5 +66,5 @@ Tree.propTypes = {
     onNavigate: func.isRequired,
     setCategoryId: func.isRequired,
     updateCategories: func.isRequired,
-    tabIndex: func.isRequired
+    tabIndex: string
 };
diff --git a/packages/venia-ui/lib/components/Gallery/__tests__/__snapshots__/item.spec.js.snap b/packages/venia-ui/lib/components/Gallery/__tests__/__snapshots__/item.spec.js.snap
@@ -65,6 +65,7 @@ exports[`renders correctly with valid item data 1`] = `
   className="root"
 >
   <a
+    aria-label="Test Product"
     className="images"
     href="/strive-shoulder-pack.html"
     onClick={[Function]}

diff --git a/packages/venia-ui/lib/components/Gallery/item.js b/packages/venia-ui/lib/components/Gallery/item.js
@@ -85,6 +85,7 @@ const GalleryItem = props => {
     return (
         <div data-cy="GalleryItem-root" className={classes.root} ref={itemRef}>
             <Link
+                aria-label={name}
                 onClick={handleLinkClick}
                 to={productLink}
                 className={classes.images}