Issues/34507 - $_item->getHasChildren() returns true when the pagination is not there for the cart and returns null when the cart is with pagination.

[artskirk]

$_item->getHasChildren() in Magento_Checkout/cart/item/default.phtml returns true when the pagination is not there for the cart and returns null when the cart is with pagination.

Description (*)

I have removed addFieldToFilter method before cart pagination. Added an additional method filterCollection method that
excludes the items that can't be displayed directly.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes $_item->getChildren() returns empty array for parent cart items when cart is paginated #34507

Manual testing scenarios (*)

Steps followed to reproduce issue:

1. Added configurable and non-configurable products to the cart.

2. Print the $_item->getHasChildren() property on the $_items in in Magento_Checkout/cart/item/default.phtml

Observe the function output with pagination and without pagination for the cart.

Expected Result
$_item->getHasChildren() returns true when the pagination is not there for the cart and returns true when the cart is with pagination. (See the attached screenshot)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @artskirk. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[manavluhar]

@artskirk kindly sign the Adobe CLA for running automated tests.

[artskirk]

CLA Signed

[Gerke-W]

This solution does fix the issue with the $_item->getChilderen() returning null.

However it solution is first colecting both the simple and the configurable, then afterwards it is deleting the item with a parent id. This is done after the pagination has been set as a result the item count is decreased for a single page.

For a full page with one configurable product this does mean there will be 20 products collected, then 1 is removed resulting in only 19 shown items.

In short, this breaks the pagination for the cart.