Updated monolog/monolog to 2.26.1 #33226

konarshankar07 · 2021-06-12T10:51:35Z

Depends on: magento/magento2-functional-testing-framework#832

Description (*)

Updated monolog/monolog to 2.26.1

Fixed Issues (if relevant)

Fixes Update monolog/monolog to the latest version #32868

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/555

m2-assistant · 2021-06-12T10:51:38Z

Hi @konarshankar07. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me platform-health instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

konarshankar07 · 2021-06-12T10:51:58Z

@magento run all tests

magento-automated-testing · 2021-06-12T10:52:05Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

konarshankar07 · 2021-06-12T11:16:50Z

@magento run all tests

magento-automated-testing · 2021-06-12T11:16:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

konarshankar07 · 2021-06-15T08:04:21Z

@magento run Static Tests

magento-automated-testing · 2021-06-15T08:04:24Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

sivaschenko · 2021-06-19T10:41:25Z

Static tests are failing as the composer.json is not updated in EE repo

Are there any partner contributors volunteers to collaborate on this PR and create corresponding EE PR to fix static tests?

Added "help wanted" label for this purpose

sivaschenko

Thanks for the pull request @konarshankar07 ! Please see my comment

sivaschenko · 2021-06-19T12:43:51Z

composer.json

@@ -65,7 +65,7 @@
        "magento/composer": "1.6.0",
        "magento/magento-composer-installer": ">=0.1.11",
        "magento/zendframework1": "~1.14.2",
-        "monolog/monolog": "^1.17",
+        "monolog/monolog": "~1.26.1",


Let's update monolog to the latest available version

Suggested change

"monolog/monolog": "~1.26.1",

"monolog/monolog": "^2.2",

sivaschenko · 2021-06-19T13:14:14Z

Removed "help wanted" label, as @drpayyne has joined to help on the commerce repo side

sivaschenko · 2021-06-19T13:16:59Z

This pull request depends on the MFTF changes (update of the same library)

sivaschenko · 2021-06-19T15:01:30Z

EE pull request added to the related: https://github.com/magento/partners-magento2ee/pull/555

This pull request will be ready to merge once changes from magento/magento2-functional-testing-framework#832 are released

sivaschenko · 2021-06-25T09:33:28Z

@magento run all tests

magento-automated-testing · 2021-06-25T09:33:34Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

jilu1 · 2021-06-30T01:16:29Z

@sivaschenko
Is branch konarshankar07:update/package-monolog-1.26.1 ready with upgraded monolog tesing? I got failed build http://10.234.231.143:8080/job/Functional-Tests-CE/4100/.

sivaschenko

Hi @konarshankar07 , can you please update the codebase for the latest monolog version.

Currently the tests are failing with error:

PHP Fatal error:  Declaration of Magento\Framework\Logger\Handler\Base::write(array $record) must be compatible with Monolog\Handler\StreamHandler::write(array $record): void in /var/www/html/lib/internal/Magento/Framework/Logger/Handler/Base.php on line 81

sivaschenko · 2021-07-01T10:04:33Z

lib/internal/Magento/Framework/composer.json

@@ -34,7 +34,7 @@
        "laminas/laminas-uri": "^2.5.1",
        "laminas/laminas-validator": "^2.6.0",
        "magento/zendframework1": "~1.14.2",
-        "monolog/monolog": "^1.17",
+        "monolog/monolog": "~1.26.1",


Suggested change

"monolog/monolog": "~1.26.1",

"monolog/monolog": "^2.2",

konarshankar07 · 2021-07-02T04:27:33Z

@magento run all tests

magento-automated-testing · 2021-07-02T04:27:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

hostep · 2021-07-15T19:08:57Z

Would love to see this happen, as monolog v2 comes with a new datetime format that includes timezone information.

I was just researching this topic accidentally before running into this PR, because I think it could be very helpful in reading log files and I always get confused about the timestamps in Magento log files because it's currently not clear what timezone they are representing.

Alternatively, if this upgrade would take too much time to get approved, we could change the second parameter of the LineFormatter object that is created over here to Y-m-d\TH:i:sP. That would also solve my need.

Just FYI 🙂

andrewbess · 2021-07-16T20:59:47Z

Hello @hostep
We are actively working on updating the monolog to version 2.3.1 in new PRs.
This PR will be closed because of contributor doesn't continue working on this PR.
New PRs:
#33497
magento/magento2-functional-testing-framework#854

sivaschenko · 2021-07-21T09:54:04Z

Closing in favour to finalized #33497

m2-assistant · 2021-07-21T09:54:06Z

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Updated monolog/monolog to 2.26.1

df05942

m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 12, 2021

m2-community-project bot added the Progress: pending review label Jun 12, 2021

Updated framework composer,json

8b559b3

sivaschenko added the help wanted label Jun 19, 2021

m2-community-project bot assigned sivaschenko Jun 19, 2021

m2-community-project bot added Progress: review and removed Progress: pending review labels Jun 19, 2021

sivaschenko added the Project: Platform Health label Jun 19, 2021

sivaschenko requested changes Jun 19, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Jun 19, 2021

sivaschenko removed the help wanted label Jun 19, 2021

sivaschenko added the has dependency label Jun 19, 2021

drpayyne mentioned this pull request Jun 19, 2021

Updated monolog/monolog to ^2.2 magento/magento2-functional-testing-framework#832

Merged

5 tasks

Fixed merge update

b50917b

m2-community-project bot added Progress: on hold and removed Progress: needs update labels Jun 23, 2021

magento#32868: Temporary refrence to related MFTF changes for testing

d8af75b

sivaschenko requested changes Jul 1, 2021

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: on hold labels Jul 1, 2021

Updated monolog package verion in framework composer.json

d2c4143

sivaschenko closed this Jul 21, 2021

m2-community-project bot removed the Progress: needs update label Jul 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated monolog/monolog to 2.26.1 #33226

Updated monolog/monolog to 2.26.1 #33226

konarshankar07 commented Jun 12, 2021 •

edited by sivaschenko

Loading

m2-assistant bot commented Jun 12, 2021

konarshankar07 commented Jun 12, 2021

magento-automated-testing bot commented Jun 12, 2021

konarshankar07 commented Jun 12, 2021

magento-automated-testing bot commented Jun 12, 2021

konarshankar07 commented Jun 15, 2021

magento-automated-testing bot commented Jun 15, 2021

sivaschenko commented Jun 19, 2021 •

edited

Loading

sivaschenko left a comment

sivaschenko Jun 19, 2021

sivaschenko commented Jun 19, 2021

sivaschenko commented Jun 19, 2021

sivaschenko commented Jun 19, 2021

sivaschenko commented Jun 25, 2021

magento-automated-testing bot commented Jun 25, 2021

jilu1 commented Jun 30, 2021 •

edited

Loading

sivaschenko left a comment

sivaschenko Jul 1, 2021

konarshankar07 commented Jul 2, 2021

magento-automated-testing bot commented Jul 2, 2021

hostep commented Jul 15, 2021

andrewbess commented Jul 16, 2021

sivaschenko commented Jul 21, 2021

m2-assistant bot commented Jul 21, 2021

Updated monolog/monolog to 2.26.1 #33226

Updated monolog/monolog to 2.26.1 #33226

Conversation

konarshankar07 commented Jun 12, 2021 • edited by sivaschenko Loading

Description (*)

Fixed Issues (if relevant)

Related Pull Requests

m2-assistant bot commented Jun 12, 2021

konarshankar07 commented Jun 12, 2021

magento-automated-testing bot commented Jun 12, 2021

konarshankar07 commented Jun 12, 2021

magento-automated-testing bot commented Jun 12, 2021

konarshankar07 commented Jun 15, 2021

magento-automated-testing bot commented Jun 15, 2021

sivaschenko commented Jun 19, 2021 • edited Loading

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko Jun 19, 2021

Choose a reason for hiding this comment

sivaschenko commented Jun 19, 2021

sivaschenko commented Jun 19, 2021

sivaschenko commented Jun 19, 2021

sivaschenko commented Jun 25, 2021

magento-automated-testing bot commented Jun 25, 2021

jilu1 commented Jun 30, 2021 • edited Loading

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko Jul 1, 2021

Choose a reason for hiding this comment

konarshankar07 commented Jul 2, 2021

magento-automated-testing bot commented Jul 2, 2021

hostep commented Jul 15, 2021

andrewbess commented Jul 16, 2021

sivaschenko commented Jul 21, 2021

m2-assistant bot commented Jul 21, 2021

konarshankar07 commented Jun 12, 2021 •

edited by sivaschenko

Loading

sivaschenko commented Jun 19, 2021 •

edited

Loading

jilu1 commented Jun 30, 2021 •

edited

Loading