Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[32015][PR to 2.4-develop] Marked Catalog*, Checkout, Cms, ConfigurableProduct interfaces as API #32725

Closed
wants to merge 35 commits into from
Closed

[32015][PR to 2.4-develop] Marked Catalog*, Checkout, Cms, ConfigurableProduct interfaces as API #32725

wants to merge 35 commits into from

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR fixes #32015

Related Pull Requests

#32175

Fixed Issues (if relevant)

  1. Fixes Mark Catalog*, Checkout, Cms, ConfigurableProduct interfaces as API #32015>

vlmed and others added 28 commits April 2, 2021 16:31
@vlmed
Mark Catalog interfaces as API
117fe4d
@vlmed
Fixed static tests. Mark Catalog/Model/ResourceModel/Product/Indexer/…
bdff3f8 
…Price/IndexTableStructure.php as API
@vlmed
Mark UrlRewriteGraphQl, User, Vault, Webapi, Widget and Wishlist inte…
ce71c85 
…rfaces as API
@engcom-Hotel @vlmed
Static test has been fixed
dad0fc3
@engcom-Hotel @vlmed
refactoring
1e8836a
@vlmed
Marked Factory classes as API
5d994f6
@vlmed
Fixed Satic test. Mark lib/internal/Magento/Framework/Api/ExtensionAt…
90fdf5f 
…tribute/JoinData.php as API
@vlmed
Fixed static tests. Marked as API lib/internal/Magento/Framework/DB/L…
559575e 
…oggerInterface.php
@mrtuvn
Mark Framework interfaces as API part 9
81ec7c9 
update


update


up
@mrtuvn
Mark Framework interfaces as API part 8
cc3329e 
update
@mrtuvn
Mark Framework interfaces as API part 7
7e9365b 
update
@mrtuvn
Mark Framework Interfaces as API part 3
eedf8fc 
fix static


update


update


fix non-public references 


revert change return value interface
@mrtuvn
Mark Framework interfaces as API part 1
61f8d7e 
update
@mrtuvn
Mark Various Modules interfaces as API
6815764
@mrtuvn
Mark classes and interfaces as API part 5
47ce030
@mrtuvn
Mark classes and interfaces as API part 4
90f00d8
@mrtuvn
Mark classes and interfaces as API part 6
3f89f03 
update
@mrtuvn
Update Config.php
70d5524 
revert add strict_types
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
3baab6e 
…2-32681' into api-changes-delivery
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
e526fd7 
…2-32680' into api-changes-delivery
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
c9a14b1 
…2-32682' into api-changes-delivery
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
47cc32d 
…2-32661' into api-changes-delivery
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
8da2b9f 
…2-32151' into api-changes-delivery
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
e1eb785 
…2-32659' into api-changes-delivery
@Usik2203
marked as api
0a21b87
@Usik2203
minor adjustments
b0db38c
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
39c20d2 
…2-32156' into api-changes-delivery
Merge remote-tracking branch 'magento-engcom/imported-magento-magento…
382c055 
…2-32070' into api-changes-delivery
@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2021

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 13, 2021
@magento-engcom-team magento-engcom-team added Component: multiple Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 13, 2021
@Usik2203
Copy link
Contributor Author

@magento run all tests

Gabriel Galvao da Gama and others added 4 commits April 13, 2021 11:45
@gabrieldagama gabrieldagama mentioned this pull request Apr 13, 2021
Closed
4 tasks
@coderimus coderimus self-assigned this Apr 13, 2021
@gabrieldagama gabrieldagama changed the base branch from 2.4-develop to api-changes-develop April 13, 2021 13:12
@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203 Usik2203 changed the base branch from api-changes-develop to 2.4-develop April 22, 2021 12:42
@Usik2203
Copy link
Contributor Author

@magento run all tests

@Usik2203
Copy link
Contributor Author

Closed in favour of #32816

@Usik2203 Usik2203 closed this Apr 22, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2021

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@coderimus coderimus

Labels
Component: multiple Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark Catalog*, Checkout, Cms, ConfigurableProduct interfaces as API
7 participants
@Usik2203 @gabrieldagama @coderimus @magento-engcom-team @vlmed @engcom-Hotel @mrtuvn