Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32021 - Mark interfaces as api #32176

Closed
wants to merge 2 commits into from
Closed

32021 - Mark interfaces as api #32176

wants to merge 2 commits into from

Conversation

AndreyChorniy
Copy link
Contributor

Description (*)

This PR created for mark interfaces as api

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Mark ReleaseNotification, RemoteStorage and Sales interfaces as API #32021

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 15, 2021

Hi @AndreyChorniy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 15, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 15, 2021
@BarnyShergold BarnyShergold self-assigned this Feb 15, 2021
@BarnyShergold
Copy link

@magento run all tests

@BarnyShergold
Copy link

@magento run Functional Tests B2B

@BarnyShergold
Copy link

@magento run Database Compare

BarnyShergold
BarnyShergold requested changes Feb 16, 2021
View reviewed changes
Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B2B & Database tests are failing after several attempts - please check

@engcom-Hotel engcom-Hotel self-assigned this Feb 17, 2021
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

1 similar comment
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@BarnyShergold
Copy link

@AndreyChorniy The Database Compare & one Functional Test keep failing but I can't see why what you've added would cause these issues - this maybe a false positive. Can you check? This seems to be same fail as your other PR

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B, Database Compare

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

1 similar comment
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@gabrieldagama gabrieldagama added this to the 2.5 milestone Feb 18, 2021
@magento-engcom-team
Copy link
Contributor

Hi @BarnyShergold, thank you for the review.
ENGCOM-8799 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@BarnyShergold BarnyShergold added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 19, 2021
@gabrieldagama
Copy link
Contributor

Hi @AndreyChorniy, can you recreate this PR to the api-changes-develop branch instead? Just make sure to create a new branch from this one and cherry-pick your commit.

Thanks!

@gabrieldagama gabrieldagama mentioned this pull request Jun 8, 2021
Merged
5 tasks
@gabrieldagama
Copy link
Contributor

Closed in favour of #33178

@BarnyShergold
Copy link

Closed again as previous close didn't work.

@m2-assistant
Copy link

m2-assistant bot commented Aug 24, 2021

Hi @AndreyChorniy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarnyShergold BarnyShergold BarnyShergold approved these changes

Assignees

@BarnyShergold BarnyShergold

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: ReleaseNotification Component: RemoteStorage Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Release Line: 2.5
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
5 participants
@AndreyChorniy @BarnyShergold @engcom-Hotel @magento-engcom-team @gabrieldagama