-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MFTF] add ReloadPageActionGroup #30223
Changes from 1 commit
9713cde
52a288b
9de5f78
bb7d50b
73951dd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,8 +49,7 @@ | |
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappearAfterFlatRateSelection"/> | ||
<see selector="{{CheckoutCartSummarySection.total}}" userInput="15" stepKey="assertOrderTotalField"/> | ||
<!-- 5. Refresh browser page (F5) --> | ||
<reloadPage stepKey="reloadPage"/> | ||
<waitForPageLoad stepKey="waitForPageLoad"/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We still may consider this change as BiC (there might be extensions with before/after references to this step key). The common (a little bit dirty but still common) practice, in this case, will be replacing the old action with a comment that has the same <comment userInput="Adding comment to replace reload action and preserve Backward Compatibility" stepKey="waitForPageLoad" /> Hope it makes sense. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @rogyar |
||
<actionGroup ref="ReloadPageActionGroup" stepKey="reloadPage"/> | ||
<actionGroup ref="StorefrontAssertCartEstimateShippingAndTaxActionGroup" stepKey="assertCartEstimateShippingAndTaxAfterPageReload"/> | ||
<actionGroup ref="StorefrontAssertCartShippingMethodSelectedActionGroup" stepKey="assertFlatRateShippingMethodIsChecked"> | ||
<argument name="carrierCode" value="flatrate"/> | ||
|
@@ -71,8 +70,7 @@ | |
<!-- 9. Fill other fields --> | ||
<actionGroup ref="StorefrontFillGuestShippingInfoActionGroup" stepKey="fillOtherFieldsInCheckoutShippingSection"/> | ||
<!-- 10. Refresh browser page(F5) --> | ||
<reloadPage stepKey="reloadCheckoutPage"/> | ||
<waitForPageLoad stepKey="waitForCheckoutPageLoad"/> | ||
<actionGroup ref="ReloadPageActionGroup" stepKey="reloadCheckoutPage"/> | ||
<actionGroup ref="StorefrontAssertGuestShippingInfoActionGroup" stepKey="assertGuestShippingPersistedInfoAfterReloadingCheckoutShippingPage"/> | ||
<actionGroup ref="StorefrontAssertCheckoutShippingMethodSelectedActionGroup" stepKey="assertFreeShippingShippingMethodIsChecked"> | ||
<argument name="shippingMethod" value="Free Shipping"/> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
--> | ||
|
||
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | ||
<actionGroup name="ReloadPageActionGroup"> | ||
<annotations> | ||
<description>Reload page and wait for page load.</description> | ||
</annotations> | ||
|
||
<reloadPage stepKey="reloadPage"/> | ||
<waitForPageLoad stepKey="waitForPageLoad"/> | ||
</actionGroup> | ||
</actionGroups> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was written incorrect way ( 🤦🏻 ) so that your change is now backwards compatible.
To be backwards-compatible, you should keep old
stepKey
which is the extremely dirty way.If we can introduce this in Magento 2.5 branch - then it would be not an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lbajsarowicz
I have reverted changes for this file.
thanks