Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Add test coverage for AdminAnalytics module #29482

Merged
merged 7 commits into from
Aug 26, 2020
Merged

[MFTF] Add test coverage for AdminAnalytics module #29482

merged 7 commits into from
Aug 26, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Aug 11, 2020 •
edited by m2-assistant bot
Loading

This PR creates test for AdminAnalytics module and check is AnalyticsMetadata present in page source

Resolved issues:

  1. resolves [Issue] [MFTF] Add test coverage for AdminAnalytics module #29500: [MFTF] Add test coverage for AdminAnalytics module

@m2-assistant
Copy link

m2-assistant bot commented Aug 11, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: AdminAnalytics Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 11, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

1 similar comment
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203 Usik2203 force-pushed the add-mftf-for-admin-analytics branch from 6c1d3d7 to db43cb8 Compare August 11, 2020 17:52
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@sidolov
Copy link
Contributor

sidolov commented Aug 12, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 12, 2020
Closed
@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. and removed Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 12, 2020
@rogyar rogyar self-assigned this Aug 16, 2020
rogyar
rogyar reviewed Aug 16, 2020
View reviewed changes
app/code/Magento/AdminAnalytics/Test/Mftf/Test/AdminCheckAnalyticsTrackingTest.xml
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
</after>

<waitForPageLoad stepKey="waitForPageReloaded"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually recommend putting such actions to a separate action group. However, in this particular case, I don't think that the newly introduced action group will be reusable somehow. So, we may leave it as it is

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8017 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Aug 17, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Aug 17, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 18, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 19, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2020
@sidolov
ENGCOM-8017: [MFTF] Add test coverage for AdminAnalytics module #29482
5e50832
@magento-engcom-team magento-engcom-team merged commit 3d5a7f8 into magento:2.4-develop Aug 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: AdminAnalytics Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Add test coverage for AdminAnalytics module
6 participants
@Usik2203 @sidolov @magento-engcom-team @engcom-Alfa @engcom-Charlie @rogyar