-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MFTF] Added assertion to AssertAdminSuccessLoginActionGroup #27843
[MFTF] Added assertion to AssertAdminSuccessLoginActionGroup #27843
Conversation
Hi @Usik2203. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK :-) However funny, because this waitForElementVisible
is also kind of assertion.
Thanks for making that explicit.
Hi @lbajsarowicz, thank you for the review.
|
✔️ QA Passed |
@magento run Functional Tests CE |
Hi @Usik2203, thank you for your contribution! |
Description (*)
This PR adds assertion to
AssertAdminSuccessLoginActionGroup
Scenario:
We run

AdminLoginSuccessfulTest
and we didn't see any assertionsActual result