Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Use ActionGroup for checking category save success message. #27692

Merged
merged 1 commit into from
Apr 18, 2020
Merged

[MFTF] Use ActionGroup for checking category save success message. #27692

merged 1 commit into from
Apr 18, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 10, 2020 •
edited
Loading

Description (*)

Add AssertAdminCategorySaveSuccessMessageActionGroup for checking success message after category was saved

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz
lbajsarowicz approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Nice catch. Thank you for your contribution.

@ghost ghost assigned lbajsarowicz Apr 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7407 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 16, 2020
@engcom-Alfa engcom-Alfa self-assigned this Apr 16, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Apr 16, 2020
@lenaorobei lenaorobei added this to the 2.4.0 milestone Apr 17, 2020
@slavvka
Copy link
Member

slavvka commented Apr 17, 2020

@magento run Functional Tests CE

magento-engcom-team pushed a commit that referenced this pull request Apr 18, 2020
@slavvka
ENGCOM-7407: [MFTF] Use ActionGroup for checking category save succes…
7fe4dce 
…s message. #27692
@magento-engcom-team magento-engcom-team merged commit 7712296 into magento:2.4-develop Apr 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 18, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: CatalogUrlRewrite Component: CatalogWidget Component: Cms Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Usik2203 @magento-engcom-team @engcom-Alfa @slavvka @lbajsarowicz @lenaorobei @engcom-Echo