Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the minicart items actions alignment for tablet and desktop devices #27493

Conversation

vasilii-b
Copy link

Description (*)

This PR aims to adjust properly the minicart item actions position for tablet and desktop devices.

Related Pull Requests

  1. Make align edit and remove icon in the minicart. #26654 - Closed due to inactivity + the solution seems still to not do the job

Fixed Issues (if relevant)

  1. In the minicart edit and remove icon is not aligned. #26652: In the minicart edit and remove icon is not aligned.

Manual testing scenarios (*)

Please check the original issue.

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 30, 2020
@VitaliyBoyko VitaliyBoyko self-assigned this Mar 30, 2020
@VitaliyBoyko VitaliyBoyko self-requested a review March 30, 2020 08:50
@vasilii-b
Copy link
Author

Hi @VitaliyBoyko,
I had a look over the failed tests and see they are not related to the changes in the PR.
Can you please confirm?
Thanks!

@VitaliyBoyko
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @VitaliyBoyko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VitaliyBoyko, here is your new Magento instance.
Admin access: https://pr-27493.instances.magento-community.engineering/admin_5fd1
Login: e600c0e6 Password: 74f8420a0c93
Instance will be terminated in up to 3 hours.

@VitaliyBoyko
Copy link
Contributor

Looks good.
image

@magento-engcom-team
Copy link
Contributor

Hi @VitaliyBoyko, thank you for the review.
ENGCOM-7225 has been created to process this Pull Request
✳️ @VitaliyBoyko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@VitaliyBoyko VitaliyBoyko added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Mar 30, 2020
@VitaliyBoyko VitaliyBoyko self-requested a review March 30, 2020 15:01
@magento-engcom-team
Copy link
Contributor

Hi @VitaliyBoyko, thank you for the review.
ENGCOM-7225 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:
Add any item in the cart and check mini cart edit and the remove icon is not aligned with a qty input box.

Before:
luma
bef1
blank
bef2

After:
luma
aft1
blank
aft2

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Failed functional, integration tests not related to the changes in this PR

@m2-assistant
Copy link

m2-assistant bot commented Apr 2, 2020

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@vasilii-b vasilii-b deleted the minicart-item-action-alignment-issue branch April 2, 2020 05:21
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Cleanup Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants