Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Fix failing CMS tests due to PageBuilder conflict #27325

Merged
merged 10 commits into from
Apr 16, 2020
Merged

MFTF: Fix failing CMS tests due to PageBuilder conflict #27325

merged 10 commits into from
Apr 16, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Mar 18, 2020 •
edited by lenaorobei
Loading

Description (*)

Another day, another flaky tests introduced. Proper change in PageBuilder repository (related PR)

Fixed Issues (if relevant)

Failing CI

Manual testing scenarios (*)

Create PR and wait

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 18, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz lbajsarowicz mentioned this pull request Mar 18, 2020
Closed
4 tasks
@lbajsarowicz
Copy link
Contributor Author

@magento run all tests

Final, working version of fix.

image

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
Looks like I've had outdated develop branch for PageBuilder

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
I'm forcing a restart. That takes too much time.

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
Failures are not related with the scope of PR

@lbajsarowicz
Copy link
Contributor Author

@magento run all tests
Updated branch to restart tests

@lenaorobei
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Apr 2, 2020
@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 3, 2020
lenaorobei
lenaorobei previously approved these changes Apr 3, 2020
View reviewed changes
@ghost ghost assigned lenaorobei Apr 3, 2020
@lbajsarowicz
Copy link
Contributor Author

Of course. Not always Github editor is good solution.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7256 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Apr 13, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE

@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 15, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2020
@slavvka
ENGCOM-7256: MFTF: Fix failing CMS tests due to PageBuilder conflict #…
0c152e3 
…27325
@magento-engcom-team magento-engcom-team merged commit 153c06f into magento:2.4-develop Apr 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@lenaorobei lenaorobei lenaorobei left review comments

Assignees

@ihor-sviziev ihor-sviziev

@lenaorobei lenaorobei

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: Cms Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lbajsarowicz @lenaorobei @ihor-sviziev @magento-engcom-team @engcom-Alfa @engcom-Echo @VladimirZaets