Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary tabindex property #27138

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Removed unnecessary tabindex property #27138

merged 1 commit into from
Mar 12, 2020

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Mar 3, 2020 •
edited
Loading

Description

Removed unnecessary tabindex property causing linked issue

Related Pull Requests

Fixed Issues

  1. Possible to switch to a whole div using TAB key  adobe-stock-integration#973: Possible to switch to a whole div using TAB key

Manual testing scenarios

  1. Disable Enhanced Media Gallery
  2. Do not configure API key and client secret for Adobe Stock Integration
  3. Open Adobe Stock Panel
  4. Navigate through elements and assert entire div isn't focused as reported in issue
  5. Also, ensure The Preview images are changed if move the cursor with arrow keys in File Name field adobe-stock-integration#847 is not reproducible and linked PR added the tabindex, so we must ensure this issue is not reproducible as well

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 3, 2020

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Mar 3, 2020
@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 3, 2020
chalov-anton
chalov-anton reviewed Mar 3, 2020
View reviewed changes
Copy link
Contributor

@chalov-anton chalov-anton left a comment •
edited by engcom-Bravo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR fixes the initial issue. And also, removing the tabindex="0" doesn't influence the PR which fixes magento/adobe-stock-integration#847

@ghost ghost assigned chalov-anton Mar 3, 2020
dmytro-ch
dmytro-ch previously approved these changes Mar 3, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7021 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Mar 3, 2020
ptylek
ptylek previously approved these changes Mar 7, 2020
View reviewed changes
@ghost ghost assigned ptylek Mar 7, 2020
@ghost ghost dismissed stale reviews from dmytro-ch and ptylek March 9, 2020 11:41

Pull Request state was updated. Re-review required.

@ptylek
Copy link
Contributor

ptylek commented Mar 9, 2020

@drpayyne I tried to fix it without success. I'll pass it further so we can proceed with this MR.

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7021 has been created to process this Pull Request

@drpayyne
Copy link
Contributor Author

drpayyne commented Mar 9, 2020

Thanks @ptylek, I think this happened since you added a review after all testing was completed.

@ptylek
Copy link
Contributor

ptylek commented Mar 9, 2020

@drpayyne, yeah, maybe that's the reason. I could see that there was 1 pending review, so that's why I reviewed this PR.

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed
The whole div is not selected via TAB key switch
tab_div

@magento-engcom-team magento-engcom-team mentioned this pull request Mar 12, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Mar 12, 2020
@slavvka
ENGCOM-7021: Removed unnecessary tabindex property #27138
d130a00
@magento-engcom-team magento-engcom-team merged commit 26fe241 into magento:2.4-develop Mar 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalov-anton chalov-anton chalov-anton left review comments

@ptylek ptylek ptylek approved these changes

@dmytro-ch dmytro-ch dmytro-ch left review comments

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

@engcom-Bravo engcom-Bravo Awaiting requested review from engcom-Bravo

Assignees

@dmytro-ch dmytro-ch

@ptylek ptylek

@chalov-anton chalov-anton

@engcom-Echo engcom-Echo

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Ui Partner: EY partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@drpayyne @magento-engcom-team @engcom-Bravo @ptylek @dmytro-ch @chalov-anton @engcom-Echo