Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#27124: Update wishlist image logic to match logic on wishlist page #27125

Merged
merged 5 commits into from
Mar 19, 2020
Merged

#27124: Update wishlist image logic to match logic on wishlist page #27125

merged 5 commits into from
Mar 19, 2020

Conversation

mtbottens
Copy link

Description (*)

Updates image logic on the "Share wishlist" email to match the image logic in the my account wishlist page.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Share Wishlist Email: Image Logic Issue #27124: Share Wishlist Email: Image Logic Issue

Manual testing scenarios (*)

  1. Set Stores > Configuration > Sales > Checkout > Shopping Cart > Configurable Product Image = "Product Thumbnail Itself"
  2. Add "Olivia 1/4 Zip Light Jacket" (Size = Medium, Color = Black) to wishlist
  3. Navigate to wishlist page, and click the share wishlist button
  4. Fill in the form
  5. Share the wishlist
  6. Observe that the wishlist email is using the configurable product image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 2, 2020

Hi @mtbottens. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mtbottens, thank you for your contribution. However, for me it looks like the problem isn't related only with the image, but with the product URL as well.
So, may I ask you to update also the URL that leads to product page to auto select the configurable attributes (exactly how we have it on Wishlist page)?

Thank you.

@mtbottens
Copy link
Author

Hey @eduard13, I've updated this pull request to handle the links as mentioned.

Thanks!

@mtbottens mtbottens requested a review from eduard13 March 3, 2020 13:12
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your updates, could you please check the review notes and update the code based on them?
Also, could you please fix the failing static tests as well?
Thank you.

@mtbottens
Copy link
Author

@eduard13 Thank you for the code review, I have made the requested changes.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the adjustment.
Could you please also fix these minor recommendations and fix the failing Static Tests?

@engcom-Echo engcom-Echo self-assigned this Mar 5, 2020
@eduard13 eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 7, 2020
@eduard13
Copy link
Contributor

eduard13 commented Mar 7, 2020

@magento run Functional Tests CE, Functional Tests B2B, Functional Tests EE

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7062 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Mar 10, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @mtbottens, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants