-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#27124: Update wishlist image logic to match logic on wishlist page #27125
#27124: Update wishlist image logic to match logic on wishlist page #27125
Conversation
Hi @mtbottens. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mtbottens, thank you for your contribution. However, for me it looks like the problem isn't related only with the image, but with the product URL as well.
So, may I ask you to update also the URL that leads to product page to auto select the configurable attributes (exactly how we have it on Wishlist page)?
Thank you.
Hey @eduard13, I've updated this pull request to handle the links as mentioned. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your updates, could you please check the review notes and update the code based on them?
Also, could you please fix the failing static tests as well?
Thank you.
@eduard13 Thank you for the code review, I have made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the adjustment.
Could you please also fix these minor recommendations and fix the failing Static Tests?
@magento run Functional Tests CE, Functional Tests B2B, Functional Tests EE |
Hi @eduard13, thank you for the review. |
✔️ QA Passed |
@magento run all tests |
Failed functional tests not related to the changes in this PR |
Hi @mtbottens, thank you for your contribution! |
Description (*)
Updates image logic on the "Share wishlist" email to match the image logic in the my account wishlist page.
Related Pull Requests
N/A
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)