Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-26683: Removed get errors of cart allowing to add product to cart #27015

Merged
merged 8 commits into from
Mar 19, 2020
Merged

MC-26683: Removed get errors of cart allowing to add product to cart #27015

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
77fee57
MC-26683: Removed get errors of cart allowing to add product to cart
AleksLi Feb 25, 2020
0a79989
MC-26683: Updated description of the class
AleksLi Feb 26, 2020
af251eb
MC-26683: Some sort of example how I see the solution of this.
AleksLi Mar 6, 2020
c47a6a2
MC-26683: Added errors to the return model
AleksLi Mar 9, 2020
39ade1f
added webapi test
engcom-Charlie Mar 12, 2020
2d87219
changes requested; add out stock product to cart test
engcom-Charlie Mar 12, 2020
158f788
MC-26683: Added test case for 'Some of the products are out of stock.…
AleksLi Mar 13, 2020
fff5ce9
MC-26683: Removed unused set_guest_email.php fixture for test
AleksLi Mar 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions app/code/Magento/QuoteGraphQl/Model/Cart/AddProductsToCart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,11 @@
namespace Magento\QuoteGraphQl\Model\Cart;

use Magento\Framework\GraphQl\Exception\GraphQlInputException;
use Magento\Framework\Message\MessageInterface;
use Magento\Quote\Api\CartRepositoryInterface;
use Magento\Quote\Model\Quote;

/**
* Add products to cart
* Adding products to cart using GraphQL
*/
class AddProductsToCart
{
Expand Down Expand Up @@ -54,16 +53,6 @@ public function execute(Quote $cart, array $cartItems): void
$this->addProductToCart->execute($cart, $cartItemData);
}

if ($cart->getData('has_error')) {
$e = new GraphQlInputException(__('Shopping cart errors'));
$errors = $cart->getErrors();
foreach ($errors as $error) {
/** @var MessageInterface $error */
$e->addError(new GraphQlInputException(__($error->getText())));
}
throw $e;
}

$this->cartRepository->save($cart);
}
}