-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #26992 Add new rating is active checkbox alignment issue #27014
Fix #26992 Add new rating is active checkbox alignment issue #27014
Conversation
Hi @srsathish92. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @srsathish92, thank you for your contribution, however could you please refactor your implementation, in order to fix the alignment for other checkboxes as well?
Please check the following settings:
Stores / Tax Zones and Rates / New Tax Rate / Zip/Post is Range
Stores / Tax Rules / New Tax Rule / Additional Settings / Calculate Off Subtotal Only
Also, please take into account this issue #24761.
Thank you.
…into bug/26992-rating-checkbox-alignment
@eduard13 Good Catch, Thanks for the feedback. I believe this PR #24761 only reason for all checkbox alignment issue, So I reverted & added fix for alone. correct me If I am wrong. Test Scenarios:
|
@magento run all tests |
@magento give me test instance |
Hi @eduard13. Thank you for your request. I'm working on Magento instance for you |
Hi @eduard13, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you.
Hi @eduard13, thank you for the review.
|
Hi @ptylek, thank you for the review. |
✔️ QA Passed |
Hi @srsathish92, thank you for your contribution! |
Description (*)
This PR fix #26992, Added Style in Magento_Review module itself.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
If any please let me know the feedback's
Contribution checklist (*)