Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #26992 Add new rating is active checkbox alignment issue #27014

Merged
merged 4 commits into from
Mar 12, 2020
Merged

Fix #26992 Add new rating is active checkbox alignment issue #27014

merged 4 commits into from
Mar 12, 2020

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented Feb 25, 2020

Description (*)

This PR fix #26992, Added Style in Magento_Review module itself.

Fixed Issues (if relevant)

  1. Add New ratings Is active and checkbox alignment issue #26992: Add New ratings Is active and checkbox alignment issue

Manual testing scenarios (*)

  • GoTo Admin -> Stores -> Attributes -> Ratings -> Add new ratings -> Rating Visibility Section
  • Checkbox alignment should be in same line

Questions or comments

If any please let me know the feedback's

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@m2-assistant
Copy link

m2-assistant bot commented Feb 25, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srsathish92, thank you for your contribution, however could you please refactor your implementation, in order to fix the alignment for other checkboxes as well?
Please check the following settings:

  • Stores / Tax Zones and Rates / New Tax Rate / Zip/Post is Range
  • Stores / Tax Rules / New Tax Rule / Additional Settings / Calculate Off Subtotal Only

Also, please take into account this issue #24761.
Thank you.

@srsathish92
Copy link
Contributor Author

@eduard13 Good Catch, Thanks for the feedback. I believe this PR #24761 only reason for all checkbox alignment issue, So I reverted & added fix for alone. correct me If I am wrong.

Test Scenarios:

  • Stores / Tax Zones and Rates / New Tax Rate / Zip/Post is Range
  • Stores / Tax Rules / New Tax Rule / Additional Settings / Calculate Off Subtotal Only
  • Customer / Edit / Newsletter Tab / Subscribed to Newsletter
  • Catalog / Product / Action Attribute/ Edit / checkbox with change

@srsathish92 srsathish92 requested a review from eduard13 February 28, 2020 19:31
@eduard13
Copy link
Contributor

@magento run all tests

@eduard13
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, here is your new Magento instance.
Admin access: https://pr-27014.instances.magento-community.engineering/admin_4e8c
Login: 2f85e46b Password: 42fd08b0749c
Instance will be terminated in up to 3 hours.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you.

@eduard13 eduard13 added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix labels Mar 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7015 has been created to process this Pull Request
✳️ @eduard13, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7015 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Mar 12, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add New ratings Is active and checkbox alignment issue
6 participants