Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed disabled products from low stock report grid #26862

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Removed disabled products from low stock report grid #26862

merged 2 commits into from
Feb 26, 2020

Conversation

Mohamed-Asar
Copy link
Contributor

Description (*)

Remove disabled products from low stock report grid

Fixed Issues (if relevant)

#26838

Manual testing scenarios (*)

  1. Add Product and set the quantity to 0
  2. Disable the product
  3. Run low stock report

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @Mohamed-Asar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lenaorobei
Copy link
Contributor

@magento run Functional Tests CE

@ghost ghost assigned lenaorobei Feb 18, 2020
@lenaorobei
Copy link
Contributor

@Mohamed-Asar could you please add MFTF test to cover this scenario?

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6925 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei lenaorobei added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 18, 2020
@engcom-Delta engcom-Delta self-assigned this Feb 19, 2020
@engcom-Echo
Copy link
Contributor

I will take care of test coverage.

@engcom-Echo engcom-Echo self-assigned this Feb 21, 2020
@engcom-Echo engcom-Echo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Feb 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6925 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 26, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 26, 2020
@slavvka
ENGCOM-6925: Removed disabled products from low stock report grid #26862
967115f
@magento-engcom-team magento-engcom-team merged commit bc2eedf into magento:2.4-develop Feb 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @Mohamed-Asar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

Assignees

@lenaorobei lenaorobei

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Catalog Component: Reports Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mohamed-Asar @lenaorobei @magento-engcom-team @engcom-Echo @engcom-Delta